Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2879493003: Check if value changed when setting nested fields in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% macro encode(field, value) %} 1 {% macro encode(field, value) %}
2 {% if field.is_bit_field -%} 2 {% if field.is_bit_field -%}
3 static_cast<unsigned>({{value}}) 3 static_cast<unsigned>({{value}})
4 {%- else -%} 4 {%- else -%}
5 {{value}} 5 {{value}}
6 {%- endif %} 6 {%- endif %}
7 {% endmacro %} 7 {% endmacro %}
8 8
9 {% macro decode(field, value) %} 9 {% macro decode(field, value) %}
10 {% if field.is_bit_field -%} 10 {% if field.is_bit_field -%}
(...skipping 12 matching lines...) Expand all
23 {% endmacro %} 23 {% endmacro %}
24 24
25 {% macro setter_expression(field) %} 25 {% macro setter_expression(field) %}
26 {% if field.group_member_name -%} 26 {% if field.group_member_name -%}
27 {{field.group_member_name}}.Access()->{{field.name}} 27 {{field.group_member_name}}.Access()->{{field.name}}
28 {%- else -%} 28 {%- else -%}
29 {{field.name}} 29 {{field.name}}
30 {%- endif %} 30 {%- endif %}
31 {% endmacro %} 31 {% endmacro %}
32 32
33 {% macro set_if_changed(field, value) %}
34 {% if field.group_member_name -%}
35 if (!({{getter_expression(field)}} == {{value}}))
36 {{setter_expression(field)}} = {{value}};
37 {%- else -%}
38 {{field.name}} = {{value}};
39 {%- endif %}
40 {% endmacro %}
41
33 {% macro nonconst_ref(field) %} 42 {% macro nonconst_ref(field) %}
34 {% if field.is_bit_field -%} 43 {% if field.is_bit_field -%}
35 {{field.type_name}} 44 {{field.type_name}}
36 {%- else -%} 45 {%- else -%}
37 {{field.type_name}}& 46 {{field.type_name}}&
38 {%- endif %} 47 {%- endif %}
39 {% endmacro %} 48 {% endmacro %}
40 49
41 {% macro const_ref(field) %} 50 {% macro const_ref(field) %}
42 {% if field.is_bit_field -%} 51 {% if field.is_bit_field -%}
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 {% if subgroup.all_fields|select("in", fields_to_diff)|list|length > 0 -%} 101 {% if subgroup.all_fields|select("in", fields_to_diff)|list|length > 0 -%}
93 if ({{subgroup.member_name}}.Get() != other.{{subgroup.member_name}}.Get()) { 102 if ({{subgroup.member_name}}.Get() != other.{{subgroup.member_name}}.Get()) {
94 {{fieldwise_diff(subgroup, fields_to_diff)|indent(2, true)}} 103 {{fieldwise_diff(subgroup, fields_to_diff)|indent(2, true)}}
95 } 104 }
96 {% endif -%} 105 {% endif -%}
97 {% endfor %} 106 {% endfor %}
98 {% for field in group.fields|select("in", fields_to_diff) %} 107 {% for field in group.fields|select("in", fields_to_diff) %}
99 if ({{getter_expression(field)}} != other.{{getter_expression(field)}}) 108 if ({{getter_expression(field)}} != other.{{getter_expression(field)}})
100 return true; 109 return true;
101 {% endfor %} 110 {% endfor %}
102 {% endmacro %} 111 {% endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698