Initialize RendererSettings in ContextFactory

ui/compositor/test/fake_context_factory.cc

Index: ui/compositor/test/fake_context_factory.cc
diff --git a/ui/compositor/test/fake_context_factory.cc b/ui/compositor/test/fake_context_factory.cc
index a1f4219b75a7724c53ab2dd57ea956d2cb6846e9..f4b50fc6aa9dceb92193dc78686ab3387589e9aa 100644
--- a/ui/compositor/test/fake_context_factory.cc
+++ b/ui/compositor/test/fake_context_factory.cc
@@ -4,15 +4,49 @@
 
 #include "ui/compositor/test/fake_context_factory.h"
 
+#include "base/command_line.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "cc/base/switches.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/compositor_frame_sink_client.h"
 #include "cc/scheduler/begin_frame_source.h"
 #include "cc/scheduler/delay_based_time_source.h"
 #include "cc/test/fake_compositor_frame_sink.h"
+#include "ui/compositor/compositor_switches.h"
+#include "ui/display/display_switches.h"
+#include "ui/gfx/switches.h"
 
 namespace ui {
 
+FakeContextFactory::FakeContextFactory() {
+  // TODO(staraz):

[danakj, 2017/05/11 20:10:17]

What does this TODO mean? TODO should explain what could/should be done, what is
missing, or whatever

[Alex Z., 2017/05/12 14:12:36]

Thanks for pointing it out. It's removed.

+  renderer_settings_.partial_swap_enabled = false;

[danakj, 2017/05/11 20:10:17]

This line is a no-op:
https://cs.chromium.org/chromium/src/cc/output/renderer_settings.h?rcl=44ada2...

Maybe others here are too. Maybe we can remove everything except the map from
this method?

[Alex Z., 2017/05/12 14:12:36]

I thought you meant to explicitly set these to default values when 
you said to hardcode them as default.
They are removed.

[danakj, 2017/05/12 14:21:36]

Ah, sorry I meant to just leave them as defaults as much as possible, ie no
lines of code :)

+#if defined(OS_WIN)
+  renderer_settings_.finish_rendering_on_resize = true;
+#elif defined(OS_MACOSX)
+  renderer_settings_.release_overlay_resources_after_gpu_query = true;
+#endif
+  renderer_settings_.gl_composited_texture_quad_border = false;
+  renderer_settings_.show_overdraw_feedback = false;
+  renderer_settings_.enable_color_correct_rendering = false;
+  // Populate buffer_to_texture_target_map for all buffer usage/formats.
+  for (int usage_idx = 0; usage_idx <= static_cast<int>(gfx::BufferUsage::LAST);
+       ++usage_idx) {
+    gfx::BufferUsage usage = static_cast<gfx::BufferUsage>(usage_idx);
+    for (int format_idx = 0;
+         format_idx <= static_cast<int>(gfx::BufferFormat::LAST);
+         ++format_idx) {
+      gfx::BufferFormat format = static_cast<gfx::BufferFormat>(format_idx);
+      renderer_settings_
+          .buffer_to_texture_target_map[std::make_pair(usage, format)] =
+          GL_TEXTURE_2D;
+    }
+  }
+  renderer_settings_.disallow_non_exact_resource_reuse = false;
+}
+
+FakeContextFactory::~FakeContextFactory() = default;
+
 const cc::CompositorFrame& FakeContextFactory::GetLastCompositorFrame() const {
   return *frame_sink_->last_sent_frame();
 }
@@ -37,11 +71,6 @@ double FakeContextFactory::GetRefreshRate() const {
   return 200.0;
 }
 
-uint32_t FakeContextFactory::GetImageTextureTarget(gfx::BufferFormat format,
-                                                   gfx::BufferUsage usage) {
-  return GL_TEXTURE_2D;
-}
-
 gpu::GpuMemoryBufferManager* FakeContextFactory::GetGpuMemoryBufferManager() {
   return &gpu_memory_buffer_manager_;
 }
@@ -50,4 +79,8 @@ cc::TaskGraphRunner* FakeContextFactory::GetTaskGraphRunner() {
   return &task_graph_runner_;
 }
 
+const cc::RendererSettings& FakeContextFactory::GetRendererSettings() const {
+  return renderer_settings_;
+}
+
 }  // namespace ui