ui/compositor/compositor_util.h - Issue 2879463002: Initialize RendererSettings in ContextFactory

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/compositor/compositor_util.h

Issue 2879463002: Initialize RendererSettings in ContextFactory (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_COMPOSITOR_COMPOSITOR_UTIL_H_

	6 #define UI_COMPOSITOR_COMPOSITOR_UTIL_H_

	7

	8 #include "base/callback.h"

	9 #include "ui/compositor/compositor_export.h"

	10 #include "ui/gfx/buffer_types.h"

	11

	12 namespace cc {

	13 class RendererSettings;

	14 }

	15

	16 namespace ui {

	17

	18 COMPOSITOR_EXPORT void InitializeRendererSettings(
	danakj 2017/05/11 20:10:16 how about making this return RendererSettings inst how about making this return RendererSettings instead of taking a pointer? Alex Z. 2017/05/12 14:12:36 Done. Show quoted text On 2017/05/11 20:10:16, danakj wrote: > how about making this return RendererSettings instead of taking a pointer? Done.
	19 const base::Callback<uint32_t(gfx::BufferFormat, gfx::BufferUsage)>&

	20 texture_target_callback,

	21 cc::RendererSettings* renderer_settings);

	22

	23 } // namespace ui

	24

	25 #endif // UI_COMPOSITOR_COMPOSITOR_UTIL_H_

OLD	NEW