Initialize RendererSettings in ContextFactory

ui/compositor/test/fake_context_factory.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/test/fake_context_factory.h"
 
+#include "base/command_line.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "cc/base/switches.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/compositor_frame_sink_client.h"
 #include "cc/scheduler/begin_frame_source.h"
 #include "cc/scheduler/delay_based_time_source.h"
 #include "cc/test/fake_compositor_frame_sink.h"
+#include "ui/compositor/compositor_switches.h"
+#include "ui/display/display_switches.h"
+#include "ui/gfx/switches.h"
 
 namespace ui {
 
+FakeContextFactory::FakeContextFactory() {
+  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+  renderer_settings_.partial_swap_enabled =

[danakj, 2017/05/11 15:17:15]

Most of these are not needed for tests, I would make everything hardcoded to the
default values, unless some test is actually passing the command line switch (u
can find it in codesearch if it is, and track which ContextFactory that test
uses to see)

[Alex Z., 2017/05/11 19:25:22]

I set it to default values since nothing using either ContextFactory
is setting any of these switches.

Do you still want everything hardcoded to default now that there is a
centralized initialization function?

[danakj, 2017/05/11 20:10:16]

I think test code not using switches sounds good.

+      !command_line->HasSwitch(switches::kUIDisablePartialSwap);
+#if defined(OS_WIN)
+  renderer_settings_.finish_rendering_on_resize = true;
+#elif defined(OS_MACOSX)
+  renderer_settings_.release_overlay_resources_after_gpu_query = true;
+#endif
+  renderer_settings_.gl_composited_texture_quad_border =
+      command_line->HasSwitch(cc::switches::kGlCompositedTextureQuadBorder);
+  renderer_settings_.show_overdraw_feedback =
+      command_line->HasSwitch(cc::switches::kShowOverdrawFeedback);
+  if (command_line->HasSwitch(switches::kUIEnableRGBA4444Textures))
+    renderer_settings_.preferred_tile_format = cc::RGBA_4444;
+  renderer_settings_.enable_color_correct_rendering =
+      command_line->HasSwitch(switches::kEnableColorCorrectRendering) ||
+      command_line->HasSwitch(switches::kEnableHDR);
+  // Populate buffer_to_texture_target_map for all buffer usage/formats.
+  for (int usage_idx = 0; usage_idx <= static_cast<int>(gfx::BufferUsage::LAST);
+       ++usage_idx) {
+    gfx::BufferUsage usage = static_cast<gfx::BufferUsage>(usage_idx);
+    for (int format_idx = 0;
+         format_idx <= static_cast<int>(gfx::BufferFormat::LAST);
+         ++format_idx) {
+      gfx::BufferFormat format = static_cast<gfx::BufferFormat>(format_idx);
+      uint32_t target = GL_TEXTURE_2D;
+      renderer_settings_
+          .buffer_to_texture_target_map[std::make_pair(usage, format)] = target;
+    }
+  }
+  renderer_settings_.disallow_non_exact_resource_reuse =
+      command_line->HasSwitch(cc::switches::kDisallowNonExactResourceReuse);
+}
+
+FakeContextFactory::~FakeContextFactory() = default;
+
 const cc::CompositorFrame& FakeContextFactory::GetLastCompositorFrame() const {
   return *frame_sink_->last_sent_frame();
 }
 
 void FakeContextFactory::CreateCompositorFrameSink(
     base::WeakPtr<ui::Compositor> compositor) {
   auto frame_sink = cc::FakeCompositorFrameSink::Create3d();
   frame_sink_ = frame_sink.get();
   compositor->SetCompositorFrameSink(std::move(frame_sink));
 }
 
 scoped_refptr<cc::ContextProvider>
 FakeContextFactory::SharedMainThreadContextProvider() {
   return nullptr;
 }
 
 void FakeContextFactory::RemoveCompositor(ui::Compositor* compositor) {
   frame_sink_ = nullptr;
 }
 
 double FakeContextFactory::GetRefreshRate() const {
   return 200.0;
 }
 
-uint32_t FakeContextFactory::GetImageTextureTarget(gfx::BufferFormat format,
-                                                   gfx::BufferUsage usage) {
-  return GL_TEXTURE_2D;
-}
-
 gpu::GpuMemoryBufferManager* FakeContextFactory::GetGpuMemoryBufferManager() {
   return &gpu_memory_buffer_manager_;
 }
 
 cc::TaskGraphRunner* FakeContextFactory::GetTaskGraphRunner() {
   return &task_graph_runner_;
 }
 
+const cc::RendererSettings& FakeContextFactory::GetRendererSettings() const {
+  return renderer_settings_;
+}
+
 }  // namespace ui