Index: dashboard/dashboard/add_point_queue.py |
diff --git a/dashboard/dashboard/add_point_queue.py b/dashboard/dashboard/add_point_queue.py |
index 52f31d7a58d748b2d08b135c61356c9f4aa432e6..dab4729790a40f5f0449034f66c0e68c73bc56b5 100644 |
--- a/dashboard/dashboard/add_point_queue.py |
+++ b/dashboard/dashboard/add_point_queue.py |
@@ -178,14 +178,13 @@ def _GetParentTest(row_dict, bot_whitelist): |
units = row_dict.get('units') |
higher_is_better = row_dict.get('higher_is_better') |
improvement_direction = _ImprovementDirection(higher_is_better) |
- internal_only = _BotInternalOnly(bot_name, bot_whitelist) |
+ internal_only = BotInternalOnly(bot_name, bot_whitelist) |
benchmark_description = row_dict.get('benchmark_description') |
- parent_test = _GetOrCreateAncestors( |
- master_name, bot_name, test_name, units=units, |
- improvement_direction=improvement_direction, |
- internal_only=internal_only, |
- benchmark_description=benchmark_description) |
+ parent_test = GetOrCreateAncestors( |
+ master_name, bot_name, test_name, internal_only=internal_only, |
+ benchmark_description=benchmark_description, units=units, |
+ improvement_direction=improvement_direction) |
return parent_test |
@@ -197,7 +196,7 @@ def _ImprovementDirection(higher_is_better): |
return anomaly.UP if higher_is_better else anomaly.DOWN |
-def _BotInternalOnly(bot_name, bot_whitelist): |
+def BotInternalOnly(bot_name, bot_whitelist): |
"""Checks whether a given bot name is internal-only. |
If a bot name is internal only, then new data for that bot should be marked |
@@ -211,9 +210,9 @@ def _BotInternalOnly(bot_name, bot_whitelist): |
return bot_name not in bot_whitelist |
-def _GetOrCreateAncestors( |
- master_name, bot_name, test_name, units=None, |
- improvement_direction=None, internal_only=True, benchmark_description=''): |
+def GetOrCreateAncestors( |
+ master_name, bot_name, test_name, internal_only=True, |
+ benchmark_description='', units=None, improvement_direction=None): |
"""Gets or creates all parent Master, Bot, TestMetadata entities for a Row.""" |
master_entity = _GetOrCreateMaster(master_name) |