[Dashboard] Get or create ancestors in add_histograms_queue

dashboard/dashboard/add_histograms_queue.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """URL endpoint to add new histograms to the datastore."""
 
 import json
 
 from dashboard import add_histograms
+from dashboard import add_point_queue

[shatch, 2017/05/16 15:47:44]

Probably want to move these helpers to a common spot, but I'm fine with that as
a followup later, maybe just add a TODO mentioning it.

[eakuefner, 2017/05/19 18:51:48]

Added TODO. It's true that moving these helpers to their own file will
eventually block deleting add_point_queue.

 from dashboard.common import datastore_hooks
 from dashboard.common import request_handler
-from dashboard.common import utils
+from dashboard.common import stored_object
 from dashboard.models import histogram
 
-
 class AddHistogramsQueueHandler(request_handler.RequestHandler):
   """Request handler to process a histogram and add it to the datastore.
 
   This request handler is intended to be used only by requests using the
   task queue; it shouldn't be directly from outside.
   """
 
   def get(self):
     self.post()
 
@@ skipping 10 matching lines @@
 
     Request parameters:
       data: JSON encoding of a histogram or shared diagnostic.
       revision: a revision, given as an int.
       test_path: the test path to which this diagnostic or histogram should be
           attached.
     """
     datastore_hooks.SetPrivilegedRequest()
 
     data = self.request.get('data')
+    revision = int(self.request.get('revision'))
+    test_path = self.request.get('test_path')
+
     data_dict = json.loads(data)
-    revision = int(self.request.get('revision'))
-    test_key = utils.TestKey(self.request.get('test_path'))
     guid = data_dict['guid']
+    is_histogram = (
+        data_dict.get('type') in add_histograms.SPARSE_DIAGNOSTIC_TYPES)
+
+    test_path_parts = test_path.split('/')
+    master = test_path_parts[0]
+    bot = test_path_parts[1]
+
+    bot_whitelist = stored_object.Get(add_point_queue.BOT_WHITELIST_KEY)
+    internal_only = add_point_queue.BotInternalOnly(bot, bot_whitelist)
+
+    test_name = '/'.join(test_path_parts[2:])
+
+    extra_args = {}

[shatch, 2017/05/16 15:47:44]

Maybe move this to _GetExtraArgs() or something to that effect?

[eakuefner, 2017/05/19 18:51:48]

Done and renamed to unit_args.

+    if is_histogram:
+      unit = data_dict['unit']
+      extra_args['units'] = unit
+      # TODO(eakuefner): Port unit system to Python and use that here
+      histogram_improvement_direction = unit.split('_')[-1]
+      if histogram_improvement_direction == 'biggerIsBetter':
+        extra_args['improvement_direction'] = 'up'
+      elif histogram_improvement_direction == 'smallerIsBetter':
+        extra_args['improvement_direction'] = 'down'
+
+    # TDOO(eakuefner): Populate benchmark_description once it appears in
+    # diagnostics.
+    test_key = add_point_queue.GetOrCreateAncestors(
+        master, bot, test_name, internal_only, **extra_args).key
 
     if data_dict.get('type') in add_histograms.SPARSE_DIAGNOSTIC_TYPES:
       entity = histogram.SparseDiagnostic(
           id=guid, data=data, test=test_key, start_revision=revision,
           end_revision=revision)
     else:
       entity = histogram.Histogram(
           id=guid, data=data, test=test_key, revision=revision)
 
     entity.put()