[Payment Request] PaymentsSelectorEditItem

ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm

Index: ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm
diff --git a/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm b/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm
index 0b0cf8adc3907ce109eebe1c2358e95c23aefa2a..e9e0ed69d77eb7a99be447f1ed077da788ce0d60 100644
--- a/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm
+++ b/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm
@@ -80,6 +80,7 @@ autofill::ServerFieldType AutofillTypeFromAutofillUIType(AutofillUIType type) {
       return autofill::PHONE_HOME_WHOLE_NUMBER;
     case AutofillUITypeProfileEmailAddress:
       return autofill::EMAIL_ADDRESS;
+    case AutofillUITypeCreditCardBillingAddress:

[macourteau, 2017/05/10 19:51:16]

Why does this fallthrough to default: ? Is it intended to be in another CL? If
not, shouldn't it return something instead of hitting NOTREACHED()?

[Moe, 2017/05/11 14:17:18]

This is intended. AutofillUITypeCreditCardBillingAddress doesn't actually map to
any autofill data type. We're only using the UI type to identify the form field
for the billing address.

[macourteau, 2017/05/11 14:25:07]

Acknowledged.

     default:
       NOTREACHED();
       return autofill::UNKNOWN_TYPE;