Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2879393002: Fix language/stacktrace_rethrow_error_test_withtraceparameter_multi test (Closed)

Created:
3 years, 7 months ago by Jacob
Modified:
3 years, 7 months ago
Reviewers:
Leaf, vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix language/stacktrace_rethrow_error_test_withtraceparameter_multi test Fix is to remove unexpected frames on the stack trace by inlining all calls to determine current DDC configuration settings. BUG= R=leafp@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/61b0cbd68538ae0070edb63bbc319a93c0631604

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart View 8 chunks +9 lines, -14 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 2 chunks +2 lines, -2 lines 2 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/utils.dart View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 10 (5 generated)
Jacob
3 years, 7 months ago (2017-05-15 21:36:21 UTC) #2
vsm
lgtm
3 years, 7 months ago (2017-05-15 22:06:21 UTC) #6
Leaf
lgtm https://codereview.chromium.org/2879393002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2879393002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode484 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:484: if (!dart.__ignoreWhitelistedErrors || ($ignoreFromWhiteList == void 0)) return ...
3 years, 7 months ago (2017-05-15 22:06:40 UTC) #7
Jacob
https://codereview.chromium.org/2879393002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart (right): https://codereview.chromium.org/2879393002/diff/1/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart#newcode484 pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:484: if (!dart.__ignoreWhitelistedErrors || ($ignoreFromWhiteList == void 0)) return result; ...
3 years, 7 months ago (2017-05-15 23:27:49 UTC) #8
Jacob
3 years, 7 months ago (2017-05-15 23:27:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61b0cbd68538ae0070edb63bbc319a93c0631604 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698