Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: src/harmony-math.js

Issue 28793002: Harmony: implement Math.trunc. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 Object.defineProperty(this, "x", { writable:true }); 28 'use strict';
29 29
30 function s(v) { 30 // ES6 draft 09-27-13, section 20.2.2.28.
31 v.x = 1; 31 function MathSign(x) {
32 if (!IS_NUMBER(x)) x = NonNumberToNumber(x);
33 if (x > 0) return 1;
34 if (x < 0) return -1;
35 if (x === 0) return x;
36 return NAN;
32 } 37 }
33 38
34 function s_strict(v) { 39
35 "use strict"; 40 // ES6 draft 09-27-13, section 20.2.2.34.
36 v.x = 1; 41 function MathTrunc(x) {
42 if (!IS_NUMBER(x)) x = NonNumberToNumber(x);
Dmitry Lomov (no reviews) 2013/10/21 07:01:28 Replace with TO_NUMBER_INLINE
43 if (x > 0) return MathFloor(x);
44 if (x < 0) return MathCeil(x);
45 if (x === 0) return x;
46 return NAN;
37 } 47 }
38 48
39 function c(p) { 49
40 return {__proto__: p}; 50 function ExtendMath() {
51 %CheckIsBootstrapping();
52
53 // Set up the non-enumerable functions on the Math object.
54 InstallFunctions($Math, DONT_ENUM, $Array(
55 "sign", MathSign,
56 "trunc", MathTrunc
57 ));
41 } 58 }
42 59
43 var o1 = c(this); 60 ExtendMath();
44 var o2 = c(this);
45
46 // Initialize the store IC.
47 s(c(this));
48 s(c(this));
49 s_strict(c(this));
50 s_strict(c(this));
51
52 // Make x non-writable.
53 Object.defineProperty(this, "x", { writable:false, value:5 });
54
55 // Verify that direct setting fails.
56 o1.x = 20;
57 assertEquals(5, o1.x);
58
59 // Verify that setting through the IC fails.
60 s(o2);
61 assertEquals(5, o2.x);
62 assertThrows("s_strict(o2);", TypeError);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698