Issue 28793002: Harmony: implement Math.trunc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28793002: Harmony: implement Math.trunc. (Closed)

Created:
7 years, 2 months ago by Yang

Modified:
7 years, 2 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Harmony: implement Math.trunc. BUG=v8:2938 R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17286

Patch Set 4 : inline number conversion #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -58 lines)			Patch
M	src/harmony-math.js	View	1 2 3	2 chunks	+13 lines, -2 lines	0 comments	Download
M	src/math.js	View	1 2 3	5 chunks	+20 lines, -37 lines	0 comments	Download
A +	test/mjsunit/harmony/math-trunc.js	View	1 2 3	1 chunk	+22 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

LGTM with nits. https://codereview.chromium.org/28793002/diff/60001/src/harmony-math.js File src/harmony-math.js (right): https://codereview.chromium.org/28793002/diff/60001/src/harmony-math.js#newcode42 src/harmony-math.js:42: if (!IS_NUMBER(x)) x = NonNumberToNumber(x); Replace ...

7 years, 2 months ago (2013-10-21 07:01:28 UTC) #2

Yang

7 years, 2 months ago (2013-10-21 11:15:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r17286 (presubmit successful).

Expand Messages | Collapse Messages

Issue 28793002: Harmony: implement Math.trunc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : added comment #

Patch Set 3 : #

Patch Set 4 : inline number conversion #

Messages