Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
287923002:
Enable ServiceDiscoveryClientMdns. (Closed)
|
Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS) Modified:
6 years, 7 months ago Reviewers:
Noam Samuel CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionEnable ServiceDiscoveryClientMdns.
BUG=349645
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270745
Patch Set 1 #
Total comments: 3
Messages
Total messages: 14 (0 generated)
https://codereview.chromium.org/287923002/diff/1/chrome/browser/local_discove... File chrome/browser/local_discovery/service_discovery_shared_client.cc (right): https://codereview.chromium.org/287923002/diff/1/chrome/browser/local_discove... chrome/browser/local_discovery/service_discovery_shared_client.cc:90: return new ServiceDiscoveryClientUtility(); Does this mean that ServiceDiscoveryClientUtility and ServiceDiscoveryClientMDns could both be running at the same time on Windows?
https://codereview.chromium.org/287923002/diff/1/chrome/browser/local_discove... File chrome/browser/local_discovery/service_discovery_shared_client.cc (right): https://codereview.chromium.org/287923002/diff/1/chrome/browser/local_discove... chrome/browser/local_discovery/service_discovery_shared_client.cc:90: return new ServiceDiscoveryClientUtility(); No. Only one is alive in time. Check g_service_discovery_client. On 2014/05/14 18:35:09, Noam Samuel wrote: > Does this mean that ServiceDiscoveryClientUtility and ServiceDiscoveryClientMDns > could both be running at the same time on Windows?
https://codereview.chromium.org/287923002/diff/1/chrome/browser/local_discove... File chrome/browser/local_discovery/service_discovery_shared_client.cc (right): https://codereview.chromium.org/287923002/diff/1/chrome/browser/local_discove... chrome/browser/local_discovery/service_discovery_shared_client.cc:90: return new ServiceDiscoveryClientUtility(); On 2014/05/14 19:11:41, Vitaly Buka wrote: > No. Only one is alive in time. > Check g_service_discovery_client. > > On 2014/05/14 18:35:09, Noam Samuel wrote: > > Does this mean that ServiceDiscoveryClientUtility and > ServiceDiscoveryClientMDns > > could both be running at the same time on Windows? > Wait, so does this mean that Chrome on Windows will nondeterministically use ServiceDiscoveryClientUtility or ServiceDiscoveryClientMdns based on a race between the UI and file threads?
lgtm based on offline discussion
The CQ bit was checked by vitalybuka@chromium.org
The CQ bit was unchecked by vitalybuka@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/287923002/1
The CQ bit was checked by vitalybuka@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/287923002/1
The CQ bit was unchecked by vitalybuka@chromium.org
The CQ bit was checked by vitalybuka@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/287923002/1
Message was sent while issue was closed.
Change committed as 270745 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
