Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

Issue 2879183002: Move the ReadingListModel in a Mediator (Closed)
Patch Set: Address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
index 87d2fb517e8e900734545dc3c5e8dcb7ea5f925b..e87e1a3238672d30452b2b1eccbfe6c1468fe49c 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
@@ -23,6 +23,7 @@
#include "ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h"
#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
#import "ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h"
+#import "ios/chrome/browser/ui/reading_list/reading_list_mediator.h"
#include "ios/web/public/test/test_web_thread_bundle.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -42,14 +43,13 @@ class ReadingListCollectionViewControllerTest : public testing::Test {
testing::StrictMock<favicon::MockFaviconService> mock_favicon_service_;
std::unique_ptr<ReadingListModelImpl> reading_list_model_;
+ base::scoped_nsobject<ReadingListMediator> mediator_;
std::unique_ptr<favicon::LargeIconService> large_icon_service_;
base::scoped_nsobject<ReadingListCollectionViewController>
reading_list_view_controller_;
id mock_delegate_;
- // TODO(crbug.com/625617) When offline url can be opened, use a mock for the
- // readinglistdownloadservice.
void SetUp() override {
testing::Test::SetUp();
@@ -59,15 +59,16 @@ class ReadingListCollectionViewControllerTest : public testing::Test {
reading_list_model_.reset(new ReadingListModelImpl(
nullptr, nullptr, base::MakeUnique<base::DefaultClock>()));
+ mediator_.reset(
+ [[ReadingListMediator alloc] initWithModel:reading_list_model_.get()]);
large_icon_service_.reset(new favicon::LargeIconService(
&mock_favicon_service_, base::ThreadTaskRunnerHandle::Get(),
/*image_fetcher=*/nullptr));
reading_list_view_controller_.reset(
[[ReadingListCollectionViewController alloc]
- initWithModel:reading_list_model_.get()
- largeIconService:large_icon_service_.get()
- readingListDownloadService:nil
- toolbar:nil]);
+ initWithDataSource:mediator_
+ largeIconService:large_icon_service_.get()
+ toolbar:nil]);
mock_delegate_ = [OCMockObject
niceMockForProtocol:@protocol(

Powered by Google App Engine
This is Rietveld 408576698