Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h

Issue 2879183002: Move the ReadingListModel in a Mediator (Closed)
Patch Set: Address comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
index 26bb030030549c51bcb91e0c7bde6e00663bdb68..ec59500dc8d597caa0cb4838b0fc651c3a9bcfc7 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h
@@ -18,7 +18,7 @@ class LargeIconService;
class GURL;
@class ReadingListCollectionViewController;
@class ReadingListCollectionViewItem;
-class ReadingListDownloadService;
+@protocol ReadingListDataSource;
class ReadingListModel;
@class TabModel;
@@ -75,11 +75,9 @@ readingListCollectionViewController:
@interface ReadingListCollectionViewController
: CollectionViewController<ReadingListToolbarActions>
-- (instancetype)initWithModel:(ReadingListModel*)model
- largeIconService:(favicon::LargeIconService*)largeIconService
- readingListDownloadService:
- (ReadingListDownloadService*)readingListDownloadService
- toolbar:(ReadingListToolbar*)toolbar
+- (instancetype)initWithDataSource:(id<ReadingListDataSource>)dataSource
+ largeIconService:(favicon::LargeIconService*)largeIconService
+ toolbar:(ReadingListToolbar*)toolbar
NS_DESIGNATED_INITIALIZER;
- (instancetype)initWithStyle:(CollectionViewControllerStyle)style
NS_UNAVAILABLE;
@@ -88,11 +86,10 @@ readingListCollectionViewController:
delegate;
@property(nonatomic, weak) id<ReadingListCollectionViewControllerAudience>
audience;
+@property(nonatomic, weak) id<ReadingListDataSource> dataSource;
-@property(nonatomic, readonly) ReadingListModel* readingListModel;
-@property(nonatomic, readonly) favicon::LargeIconService* largeIconService;
-@property(nonatomic, readonly)
- ReadingListDownloadService* readingListDownloadService;
+@property(nonatomic, assign, readonly)
+ favicon::LargeIconService* largeIconService;
// Prepares this view controller to be dismissed.
- (void)willBeDismissed;

Powered by Google App Engine
This is Rietveld 408576698