Issue 2879163002: [turbofan] Properly merge compatible field access infos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2879163002: [turbofan] Properly merge compatible field access infos.

Created:
3 years, 7 months ago by Benedikt Meurer

Modified:
3 years, 7 months ago

Reviewers:
Jarin

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Properly merge compatible field access infos. For a polymorphic access to o.x we would only merge it into a single PropertyAccessInfo so far, if x is at the same offset in all maps and the property index of x (in the descriptor arrays) is the same. But that doesn't matter for code generation and blocks optimizations even. BUG=v8:6278, v8:6344, v8:6396 R=jarin@chromium.org

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/compiler/access-info.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 2883853002 Patch 40001