Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: tools/testing/dart/test_options.dart

Issue 2879153005: Add support to dart2js for option --enable-asserts. (Closed)
Patch Set: Adjusted the status of two tests and the logic of one test, to make them work with --enable-asserts Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 06ddec629ea8f66c08ab9c581d0c61a1baa5780d..5b0bfc148c2b68132421fd51a81ece28d1b4f045 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -218,6 +218,13 @@ class TestOptionsParser {
false,
type: 'bool'),
new _TestOptionSpecification(
+ 'enable_asserts',
+ 'Pass the --enable-asserts flag to dart2js',
sra1 2017/05/19 16:51:35 This should be made to work for VM tests too.
eernst 2017/05/23 17:09:55 Done.
+ ['--enable-asserts'],
+ [],
+ false,
+ type: 'bool'),
+ new _TestOptionSpecification(
'dart2js_with_kernel',
'Enable the internal pipeline in dart2js to use kernel',
['--dart2js-with-kernel'],
@@ -785,6 +792,7 @@ Note: currently only implemented for dart2js.''',
configuration['host_unchecked'] = !configuration['host_checked'];
configuration['unminified'] = !configuration['minified'];
configuration['nocsp'] = !configuration['csp'];
+ configuration['no_enable_asserts'] = !configuration['enable_asserts'];
String runtime = configuration['runtime'];
if (runtime == 'firefox') {

Powered by Google App Engine
This is Rietveld 408576698