Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2879063002: Skip native clauses when parsing directives. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip native clauses when parsing directives. Otherwise we cannot parse SDK libraries to build full graph. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8bf0b9092a7c5a54c59e509a711737d226b24240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M pkg/front_end/lib/src/incremental/file_state.dart View 3 chunks +8 lines, -1 line 0 comments Download
M pkg/front_end/test/src/incremental/mock_sdk.dart View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scheglov
3 years, 7 months ago (2017-05-14 01:25:57 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-14 12:50:32 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 8bf0b9092a7c5a54c59e509a711737d226b24240 (presubmit successful).
3 years, 7 months ago (2017-05-14 18:21:22 UTC) #5
ahe
lgtm Is this supposed to work for dart2js as well?
3 years, 7 months ago (2017-05-15 12:03:09 UTC) #6
scheglov
3 years, 7 months ago (2017-05-15 15:22:22 UTC) #7
Message was sent while issue was closed.
On 2017/05/15 12:03:09, ahe wrote:
> lgtm
> 
> Is this supposed to work for dart2js as well?

I'm not familiar with dart2js codebase and expected behaviour.

Powered by Google App Engine
This is Rietveld 408576698