Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2878963002: skip generate_kernel_test in use_sdk mode (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

skip generate_kernel_test in use_sdk mode There is no "patched_sdk" in that mode BUG= Committed: https://github.com/dart-lang/sdk/commit/846845c1c57692c6e26f44ba514cdbd79ad3c597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
TBR
3 years, 7 months ago (2017-05-12 18:36:01 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 846845c1c57692c6e26f44ba514cdbd79ad3c597 (presubmit successful).
3 years, 7 months ago (2017-05-12 18:36:14 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-15 07:25:57 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698