Makes WorkerInspectorProxy work with ExecutionContext instead of Document

third_party/WebKit/Source/core/inspector/InspectedFrames.cpp

Index: third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp b/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
index 3ce17b1b6c66ac013b9018fd918bbd3c953ebbdd..c86ece0f2cf2110ecbdc286579b0d62dc810b858 100644
--- a/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
@@ -23,6 +23,10 @@ bool InspectedFrames::Contains(LocalFrame* frame) const {
   return frame->InstrumentingAgents() == root_->InstrumentingAgents();
 }
 
+bool InspectedFrames::Contains(ExecutionContext* context) const {
+  return context->GetProbeSink() == root_->InstrumentingAgents();

[dgozman, 2017/05/15 16:39:55]

This code looks strange as is. I would not expect that InspectedFrames contains
anything but a frame. Should we instead cast to LocalFrame and call
Contains(LocalFrame*) ?

Alternatively, we can change this class to be more abstract, but I think that's
a bit premature.

[kinuko, 2017/05/15 20:09:34]

Actually this is the important bit I want to discuss a bit further.  Some
context: some Worker-related features (i.e. ServiceWorker and SharedWorker)
we're creating dummy (so-called 'shadow') LocalFrame and Document mostly because
DevTools and loading code require them, but we want to get rid of the dependency
(crbug.com/538751) and want to make them work without creating dummy
frame/document.

And InspectedFrames is one of the part that seems to need some changes in doing
this... lots of DevTools code expects that all the plumbable stuff has
LocalFrame via InspectedFrames.  I've been trying to write a patch that makes
InspectedFrames a bit more abstract and make it possible to contain a
stand-alone, frame-less ExecutionContext.  What's your gut feeling about that? 
If you have any suggestions/recommendations to move this forward they're really
appreciated!

+}
+
 LocalFrame* InspectedFrames::FrameWithSecurityOrigin(
     const String& origin_raw_string) {
   for (LocalFrame* frame : *this) {