Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 287893002: ARM64: Enable PIE on Android. (Closed)

Created:
6 years, 7 months ago by ulan
Modified:
6 years, 7 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Enable PIE on Android. BUG=373219 LOG=N R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21312

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/android.gypi View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL
6 years, 7 months ago (2014-05-14 13:10:54 UTC) #1
rmcilroy
lgtm other than nits. Thanks Ulan https://codereview.chromium.org/287893002/diff/20001/build/android.gypi File build/android.gypi (right): https://codereview.chromium.org/287893002/diff/20001/build/android.gypi#newcode218 build/android.gypi:218: ['target_arch=="arm64"', { or ...
6 years, 7 months ago (2014-05-14 14:00:33 UTC) #2
ulan
https://codereview.chromium.org/287893002/diff/20001/build/android.gypi File build/android.gypi (right): https://codereview.chromium.org/287893002/diff/20001/build/android.gypi#newcode218 build/android.gypi:218: ['target_arch=="arm64"', { On 2014/05/14 14:00:33, rmcilroy wrote: > or ...
6 years, 7 months ago (2014-05-14 14:05:23 UTC) #3
ulan
6 years, 7 months ago (2014-05-14 14:12:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698