components/safe_browsing/password_protection/password_protection_service_unittest.cc - Issue 2878813002: Trigger protected password entry request on password reuse event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/password_protection/password_protection_service_unittest.cc

Issue 2878813002: Trigger protected password entry request on password reuse event. (Closed)

Patch Set: nit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing/password_protection/password_protection_service.cc ('K') | « components/safe_browsing/password_protection/password_protection_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing/password_protection/password_protection_service_unittest.cc

diff --git a/components/safe_browsing/password_protection/password_protection_service_unittest.cc b/components/safe_browsing/password_protection/password_protection_service_unittest.cc

index 89995be2c8a723120060a2a615b91d21ecbea308..9609b15bac740609ad01fdd2de318bb5fae7971b 100644

--- a/components/safe_browsing/password_protection/password_protection_service_unittest.cc

+++ b/components/safe_browsing/password_protection/password_protection_service_unittest.cc

@@ -153,7 +153,7 @@ class PasswordProtectionServiceTest : public testing::Test {

.WillRepeatedly(testing::Return(match_whitelist));

request_ = new PasswordProtectionRequest(

- target_url, GURL(), GURL(),

+ target_url, GURL(), GURL(), std::string(),

LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE,

password_protection_service_.get(), timeout_in_ms);

request_->Start();

@@ -530,7 +530,7 @@ TEST_F(PasswordProtectionServiceTest, TestTearDownWithPendingRequests) {

.WillRepeatedly(testing::Return(false));

password_protection_service_->StartRequest(

target_url, GURL("http://foo.com/submit"), GURL("http://foo.com/frame"),

- LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE);

+ std::string(), LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE);

// Destroy password_protection_service_ while there is one request pending.

password_protection_service_.reset();