Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.h

Issue 2878813002: Trigger protected password entry request on password reuse event. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.h
diff --git a/components/safe_browsing/password_protection/password_protection_service.h b/components/safe_browsing/password_protection/password_protection_service.h
index 8f28c538700d8c18d0958765add4fceaf788d308..77eb8b38bb090e85602d17fc0ae4283ff8569c5b 100644
--- a/components/safe_browsing/password_protection/password_protection_service.h
+++ b/components/safe_browsing/password_protection/password_protection_service.h
@@ -75,10 +75,6 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
return weak_factory_.GetWeakPtr();
}
- // Checks if |url| matches CSD whitelist and record UMA metric accordingly.
- // Currently called by PasswordReuseDetectionManager on UI thread.
- void RecordPasswordReuse(const GURL& url);
-
// Looks up |settings| to find the cached verdict response. If verdict is not
// available or is expired, return VERDICT_TYPE_UNSPECIFIED. Can be called on
// any thread.
@@ -101,6 +97,7 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
void StartRequest(const GURL& main_frame_url,
const GURL& password_form_action,
const GURL& password_form_frame_url,
+ const std::string& saved_domain,
LoginReputationClientRequest::TriggerType type);
virtual void MaybeStartPasswordFieldOnFocusRequest(
@@ -108,6 +105,10 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
const GURL& password_form_action,
const GURL& password_form_frame_url);
+ virtual void MaybeStartProtectedPasswordEntryRequest(
+ const GURL& main_frame_url,
+ const std::string& saved_domain);
+
scoped_refptr<SafeBrowsingDatabaseManager> database_manager();
protected:
@@ -159,10 +160,6 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
void CheckCsdWhitelistOnIOThread(const GURL& url, bool* check_result);
- // Increases "PasswordManager.PasswordReuse.MainFrameMatchCsdWhitelist" UMA
- // metric based on input.
- void OnMatchCsdWhiteListResult(const bool* match_whitelist);
-
HostContentSettingsMap* content_settings() const { return content_settings_; }
private:

Powered by Google App Engine
This is Rietveld 408576698