components/password_manager/core/browser/password_reuse_detection_manager.cc - Issue 2878813002: Trigger protected password entry request on password reuse event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2878813002: Trigger protected password entry request on password reuse event. (Closed)

Patch Set: nit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_reuse_detection_manager.cc

diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc

index a45670fdc70596ea3a31bb804212699bf6033582..f549345cfcf0a4a47f5f2e52d62de9923c273dc1 100644

--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc

+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc

@@ -66,9 +66,7 @@ void PasswordReuseDetectionManager::OnReuseFound(

#if defined(SAFE_BROWSING_DB_LOCAL)

// TODO(jialiul): After CSD whitelist being added to Android, we should gate

// this by either SAFE_BROWSING_DB_LOCAL or SAFE_BROWSING_DB_REMOTE.

- safe_browsing::PasswordProtectionService* password_protection_service =

- client_->GetPasswordProtectionService();

- password_protection_service->RecordPasswordReuse(main_frame_url_);

+ client_->CheckProtectedPasswordEntry(legitimate_domain);

#endif

}