Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 2878813002: Trigger protected password entry request on password reuse event. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index aa638f293be28c40a3281e9292a9a1a49df7e2e1..7df089164774f9b8c4c5c23cd98e962cbccce25c 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -418,10 +418,24 @@ void ChromePasswordManagerClient::CheckSafeBrowsingReputation(
safe_browsing::PasswordProtectionService* pps =
GetPasswordProtectionService();
if (pps) {
+ // TODO(jialiul): Pass in web_content() instead of GetMainFrameURL(), such
+ // that web_content can be used to display safe browsing interstitial.
pps->MaybeStartPasswordFieldOnFocusRequest(GetMainFrameURL(), form_action,
frame_url);
}
}
+
+void ChromePasswordManagerClient::CheckProtectedPasswordEntry(
+ const std::string& password_saved_domain) {
+ safe_browsing::PasswordProtectionService* pps =
+ GetPasswordProtectionService();
+ if (pps) {
+ // TODO(jialiul): Pass in web_content() instead of GetMainFrameURL(), such
+ // that web_content can be used to display safe browsing interstitial.
+ pps->MaybeStartProtectedPasswordEntryRequest(GetMainFrameURL(),
+ password_saved_domain);
+ }
+}
#endif
// TODO(crbug.com/706392): Fix password reuse detection for Android.

Powered by Google App Engine
This is Rietveld 408576698