Begin writing a TypeInferenceListener interface.

Begin writing a TypeInferenceListener interface.

In the long term, this is intended to be used to communicate the
results of type inference from the front_end to analyzer.  In the
short term, it can be used to debug type inference (by uncommenting
the print statements in type_inference_listener.dart).

R=scheglov@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b5bc14c0b4cb7c3dd30f5eb2ddd91e6f8efc0bca

[Paul Berry, 2017-05-12 19:57:57]

paulberry@google.com changed reviewers:
+ danrubel@google.com, scheglov@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-12 20:13:14]

lgtm

Not sure about the .iml files? Did you mean to include those in this CL?

the question below is just for my curiosity since I have less familiarity with
the inference code at this moment.

https://codereview.chromium.org/2878733006/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/2878733006/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:116:
inferExpression(operand, null, false);
is eventually the idea that if typeNeeded is false you can skip some of the
recursive calls in places like this?

[scheglov, 2017-05-12 20:16:15]

LGTM

[Paul Berry, 2017-05-12 20:22:13]

On 2017/05/12 20:13:14, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
> Not sure about the .iml files? Did you mean to include those in this CL?

We just had a discussion about the .iml files here in Portland.  I'm going to
remove them from the repo, so they won't show up in diffs anymore.

[Paul Berry, 2017-05-12 20:22:22]

https://codereview.chromium.org/2878733006/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/2878733006/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:116:
inferExpression(operand, null, false);
On 2017/05/12 20:13:14, Siggi Cherem (dart-lang) wrote:
> is eventually the idea that if typeNeeded is false you can skip some of the
> recursive calls in places like this?

We can't skip the recursive calls (they are needed because it's possible that
subexpressions contain variable references that need to be promoted, closures
that need to have type inference performed within them, ets) but we can skip
some of the type manipulations.

[Paul Berry, 2017-05-12 20:31:29]

Description was changed from

==========
Begin writing a TypeInferenceListener interface.

In the long term, this is intended to be used to communicate the
results of type inference from the front_end to analyzer.  In the
short term, it can be used to debug type inference (by uncommenting
the print statements in type_inference_listener.dart).
==========

to

==========
Begin writing a TypeInferenceListener interface.

In the long term, this is intended to be used to communicate the
results of type inference from the front_end to analyzer.  In the
short term, it can be used to debug type inference (by uncommenting
the print statements in type_inference_listener.dart).

R=scheglov@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b5bc14c0b4cb7c3dd30f5eb2ddd91e6f8efc0bca
==========

[Paul Berry, 2017-05-12 20:31:31]

Committed patchset #1 (id:1) manually as
b5bc14c0b4cb7c3dd30f5eb2ddd91e6f8efc0bca (presubmit successful).