Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html

Issue 2878613002: INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur. (Closed)
Patch Set: rename FrameSelection::NotifyLayoutObjectOfSelectionChange() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html b/third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html
new file mode 100644
index 0000000000000000000000000000000000000000..88910783e0e9ce431cdf329eb1c2f686a1a74dd1
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<body>
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
+
+<input>
+
+<script>
+var t = async_test('selectionStart/selectionEnd should be kept after input type changes.');
+t.step(() => {
+ var element = document.querySelector('input');
+ element.value = '';
+ element.focus();
+ eventSender.keyDown('c');
+ assert_equals(element.selectionStart, 1);
+ element.type = 'button';
+ assert_equals(element.selectionStart, null);
yoichio 2017/05/12 01:54:00 It doesn't make sense of "selectionStart/End on bu
tkent 2017/05/12 02:01:46 It's a spec'ed behavior.
+ element.type = 'text';
+
+ // TODO(tkent): We need some delay before checking selectionStart because
+ // input type change doesn't update selectionStart immediately to avoid force
+ // layout. crbug.com/721217
+ setTimeout(t.step_func_done(() => {
+ assert_equals(element.selectionStart, 1);
+ }), 1);
+});
+</script>
+</body>

Powered by Google App Engine
This is Rietveld 408576698