third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html - Issue 2878613002: INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/text/text-selection-after-type-change.html

Issue 2878613002: INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur. (Closed)

Patch Set: Cache in TextControlElement::DefaultEventHandler() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/text-control-selection-after-blur.html ('k') | third_party/WebKit/Source/core/html/TextControlElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5

	6 <input>

	7

	8 <script>

	9 var t = async_test('selectionStart/selectionEnd should be kept after input type changes.');

	10 t.step(() => {

	11 var element = document.querySelector('input');
	yosin_UTC9 2017/05/12 04:03:52 nit: Please add: \|assert_exists(window, 'eventSend nit: Please add: \|assert_exists(window, 'eventSender');\| tkent 2017/05/12 08:41:07 Done. Show quoted text On 2017/05/12 at 04:03:52, yosin_UTC9 wrote: > nit: Please add: \|assert_exists(window, 'eventSender');\| Done.
	12 element.value = '';

	13 element.focus();

	14 eventSender.keyDown('c');

	15 assert_equals(element.selectionStart, 1);

	16 element.type = 'button';

	17 assert_equals(element.selectionStart, null);

	18 element.type = 'text';

	19

	20 // TODO(tkent): We need some delay before checking selectionStart because

	21 // input type change doesn't update selectionStart immediately to avoid force

	22 // layout. crbug.com/721217

	23 setTimeout(t.step_func_done(() => {
	yosin_UTC9 2017/05/12 04:03:52 nit: How about using t.step_timeout()[1]? [1] "Ti nit: How about using t.step_timeout()[1]? [1] "Timeouts in Tests" http://web-platform-tests.org/writing-tests/testharness-api.html tkent 2017/05/12 08:41:07 Done. Show quoted text On 2017/05/12 at 04:03:52, yosin_UTC9 wrote: > nit: How about using t.step_timeout()[1]? > > [1] "Timeouts in Tests" http://web-platform-tests.org/writing-tests/testharness-api.html Done.
	24 assert_equals(element.selectionStart, 1);

	25 }), 1);

	26 });

	27 </script>

	28 </body>

OLD	NEW