Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2878593003: Restart servers before retrying layout tests (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
qyearsley, wkorman
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restart servers before retrying layout tests crbug.com/720511 seems caused by some server issues. The flaky tests often fail when run with all other tests but almost always succeed if run separately. I guess some test run before these tests caused the server in a special state to return "internal error" for the tests. Restarting the server might let the tests pass on retry to avoid the tests from breaking bots. BUG=720511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Xianzhu
3 years, 7 months ago (2017-05-11 17:21:19 UTC) #2
Xianzhu
Unfortunately, this doesn't fix the issue. The tests still failed in retries.
3 years, 7 months ago (2017-05-11 18:09:06 UTC) #6
qyearsley
On 2017/05/11 at 18:09:06, wangxianzhu wrote: > Unfortunately, this doesn't fix the issue. The tests ...
3 years, 7 months ago (2017-05-11 20:07:46 UTC) #7
Xianzhu
3 years, 7 months ago (2017-05-11 20:44:05 UTC) #8
Message was sent while issue was closed.
On 2017/05/11 20:07:46, qyearsley wrote:
> On 2017/05/11 at 18:09:06, wangxianzhu wrote:
> > Unfortunately, this doesn't fix the issue. The tests still failed in
retries.
> 
> So this CL was a test for a potential fix but it appears that this doesn't fix
> the issue so we don't want to commit this, right?

Yes.

I was quite confident when requesting review, but turned out to be misled by
crbug.com/721466.

Powered by Google App Engine
This is Rietveld 408576698