Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2878553003: Use Null argument for callback arity check in async_error (Closed)

Created:
3 years, 7 months ago by Leaf
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use Null argument for callback arity check in async_error. Avoid relying on fuzzy arrow semantics by using Null for the callback type parameter to be checked against. Any function of the right arity will pass the "is" check. BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/8cdcfb98e2641f6043259309e8fa9157356c842d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/async/async_error.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
3 years, 7 months ago (2017-05-11 20:01:22 UTC) #3
Lasse Reichstein Nielsen
lgtm
3 years, 7 months ago (2017-05-11 22:19:23 UTC) #4
Leaf
3 years, 7 months ago (2017-05-12 00:36:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8cdcfb98e2641f6043259309e8fa9157356c842d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698