Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2878543006: Remove the argument from main in a test (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)
Modified:
3 years, 7 months ago
Reviewers:
jensj, Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the argument from main in a test Dartium looks for main() with no arguments. BUG= R=jensj@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/aacbe6d0ac561cf0253d2057fc279bd355067023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/kernel/unsorted/generic_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-11 12:53:45 UTC) #2
Bill Hesse
lgtm
3 years, 7 months ago (2017-05-11 12:54:14 UTC) #3
jensj
lgtm
3 years, 7 months ago (2017-05-11 12:54:22 UTC) #4
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-11 12:55:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aacbe6d0ac561cf0253d2057fc279bd355067023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698