Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js

Issue 2878543004: [DevTools] Fix UI.EmptyWidget scrollbars (Closed)
Patch Set: Fixed failing test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js b/third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js
index 8b140636b65cf148ae6aad2747d3172e4e5505e4..c13c44fb8ca64cbdbfb1244bbc9451ab5f7a6e6f 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js
@@ -38,8 +38,9 @@ UI.EmptyWidget = class extends UI.VBox {
constructor(text) {
super();
this.registerRequiredCSS('ui/emptyWidget.css');
- this.element.classList.add('empty-view');
- this.textElement = this.element.createChild('h2');
+ this.element.classList.add('empty-view-scroller');
+ this._panel = this.element.createChild('div', 'empty-view');
caseq 2017/05/20 00:49:05 nit: panel is a bit overloaded. _contentElement or
eostroukhov 2017/05/22 22:21:16 Done.
+ this.textElement = this._panel.createChild('h2');
caseq 2017/05/20 00:49:05 Can we make it private? I don't think it's used ou
eostroukhov 2017/05/22 22:21:16 Done.
this.textElement.textContent = text;
}
@@ -47,7 +48,7 @@ UI.EmptyWidget = class extends UI.VBox {
* @return {!Element}
*/
appendParagraph() {
- return this.element.createChild('p');
+ return this._panel.createChild('p');
caseq 2017/05/20 00:49:05 Shouldn't this be under textElement?
eostroukhov 2017/05/22 22:21:16 I don't think so. textElement is a main text, that
}
/**

Powered by Google App Engine
This is Rietveld 408576698