Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2878543003: Hook up Reader Mode InfoBar (Closed)
Patch Set: fix disabled test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 27c46ed667dec4df0a9416d31ac048f754bda2f8..39ff8266d77f06b6028e5b0a415b842eaa3ba433 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -761,10 +761,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (ReaderModeManager.isEnabled(this)) {
mReaderModeManager = new ReaderModeManager(getTabModelSelector(), this);
- if (mToolbarManager != null) {
- mToolbarManager.addFindToolbarObserver(
- mReaderModeManager.getFindToolbarObserver());
- }
}
TraceEvent.end("ChromeActivity:CompositorInitialization");
@@ -1336,11 +1332,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
* @return Whether the app menu should be shown.
*/
public boolean shouldShowAppMenu() {
- // Do not show the menu if Contextual Search or Reader Mode panel is opened.
- // TODO(mdjones): This could potentially be handled by the OverlayPanelManager or as
- // an event if the panels were SceneOverlays.
- if ((mContextualSearchManager != null && mContextualSearchManager.isSearchPanelOpened())
- || (mReaderModeManager != null && mReaderModeManager.isPanelOpened())) {
+ // Do not show the menu if Contextual Search panel is opened.
+ if (mContextualSearchManager != null && mContextualSearchManager.isSearchPanelOpened()) {
return false;
}
@@ -1641,8 +1634,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mCompositorViewHolder.setFullscreenHandler(getFullscreenManager());
mCompositorViewHolder.setUrlBar(urlBar);
mCompositorViewHolder.onFinishNativeInitialization(getTabModelSelector(), this,
- getTabContentManager(), contentContainer, mContextualSearchManager,
- mReaderModeManager);
+ getTabContentManager(), contentContainer, mContextualSearchManager);
if (controlContainer != null
&& DeviceClassManager.enableToolbarSwipe()) {

Powered by Google App Engine
This is Rietveld 408576698