Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2565)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java

Issue 2878543003: Hook up Reader Mode InfoBar (Closed)
Patch Set: fix tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
index 23e115f2a52abf5b5c1cba05939f8efc06fbd396..8d7749ea93d333aaa28d12355448a1d8a821ba9d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
@@ -12,6 +12,8 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel;
+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
import org.chromium.chrome.browser.dom_distiller.ReaderModeManager;
import org.chromium.chrome.browser.tab.Tab;
@@ -49,17 +51,17 @@ public class ReaderModeInfoBar extends InfoBar {
prompt.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
- // TODO(mdjones): Trigger navigation from manager.
+ sManager.navigateToReaderMode();
}
});
layout.addContent(prompt, 1f);
}
+ @Override
public void onCloseButtonClicked() {
super.onCloseButtonClicked();
-
- // TODO(mdjones): Notifiy the manager that the infobar was closed.
+ sManager.onClosed(StateChangeReason.CLOSE_BUTTON);
}
/**

Powered by Google App Engine
This is Rietveld 408576698