Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5214)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2878543003: Hook up Reader Mode InfoBar (Closed)
Patch Set: fix tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 289dad8178c97d3332aba8c2c1dae7a747c6ef29..396435090e6dc3665d1975e2b5535d095a15972b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -767,10 +767,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (ReaderModeManager.isEnabled(this)) {
mReaderModeManager = new ReaderModeManager(getTabModelSelector(), this);
- if (mToolbarManager != null) {
- mToolbarManager.addFindToolbarObserver(
- mReaderModeManager.getFindToolbarObserver());
- }
}
TraceEvent.end("ChromeActivity:CompositorInitialization");
@@ -1343,11 +1339,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
* @return Whether the app menu should be shown.
*/
public boolean shouldShowAppMenu() {
- // Do not show the menu if Contextual Search or Reader Mode panel is opened.
- // TODO(mdjones): This could potentially be handled by the OverlayPanelManager or as
- // an event if the panels were SceneOverlays.
- if ((mContextualSearchManager != null && mContextualSearchManager.isSearchPanelOpened())
- || (mReaderModeManager != null && mReaderModeManager.isPanelOpened())) {
+ // Do not show the menu if Contextual Search panel is opened.
+ if (mContextualSearchManager != null && mContextualSearchManager.isSearchPanelOpened()) {
return false;
}
@@ -1648,8 +1641,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mCompositorViewHolder.setFullscreenHandler(getFullscreenManager());
mCompositorViewHolder.setUrlBar(urlBar);
mCompositorViewHolder.onFinishNativeInitialization(getTabModelSelector(), this,
- getTabContentManager(), contentContainer, mContextualSearchManager,
- mReaderModeManager);
+ getTabContentManager(), contentContainer, mContextualSearchManager);
if (controlContainer != null
&& DeviceClassManager.enableToolbarSwipe()) {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698