Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: components/password_manager/core/browser/form_fetcher.h

Issue 2878463003: Introduce SuppressedHTTPSFormFetcher. (Closed)
Patch Set: Polish. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/form_fetcher.h
diff --git a/components/password_manager/core/browser/form_fetcher.h b/components/password_manager/core/browser/form_fetcher.h
index bfbd22f770983649d45948cca277106673f6ee5d..05400dc8b1cd3df8d51be7fa722224fd0767138b 100644
--- a/components/password_manager/core/browser/form_fetcher.h
+++ b/components/password_manager/core/browser/form_fetcher.h
@@ -71,6 +71,23 @@ class FormFetcher {
virtual const std::vector<const autofill::PasswordForm*>&
GetFederatedMatches() const = 0;
+ // When this instance fetches forms for an HTTP origin: Returns credentials,
+ // if any, found for the HTTPS version of that origin. These results are
+ // queried on a best-effort basis, might be somewhat stale, and are normally
+ // available shortly after the first Consumer::ProcessMatches callback.
+ //
+ // When there exists no precisely matching HTTP credentials for an origin, but
+ // there are suppressed HTTPS credentials, that could indicate a premature
+ // `move-to-HTTPS` migration, or simply that the site serves its sign-up or
+ // some of its sign-in forms over HTTPS, while others still over HTTP.
+ virtual const std::vector<const autofill::PasswordForm*>&
+ GetSuppressedHTTPSForms() const = 0;
+
+ // Whether querying the results for GetSuppressedHTTPSForms was attempted and
+ // did complete at least once during the lifetime of this instance, regardless
+ // of whether there have been any suppressed HTTPS forms.
+ virtual bool DidCompleteQueryingSuppressedHTTPSForms() const = 0;
+
// Fetches stored matching logins. In addition the statistics is fetched on
// platforms with the password bubble. This is called automatically during
// construction and can be called manually later as well to cause an update

Powered by Google App Engine
This is Rietveld 408576698