Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2878463003: Introduce SuppressedHTTPSFormFetcher. (Closed)
Patch Set: Polish. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/credential_manager_impl.cc
diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc
index 2b93023d44a65918ded02bf99e64eea2523aaea4..ca08d69633dc7bd3c913351401b1c8bdd2d111bc 100644
--- a/components/password_manager/content/browser/credential_manager_impl.cc
+++ b/components/password_manager/content/browser/credential_manager_impl.cc
@@ -79,9 +79,11 @@ void CredentialManagerImpl::Store(const CredentialInfo& credential,
std::unique_ptr<autofill::PasswordForm> observed_form =
CreateObservedPasswordFormFromOrigin(origin);
- // Create a custom form fetcher with suppressed HTTP->HTTPS migration.
+ // Create a custom form fetcher without HTTP->HTTPS migration, as well as
+ // without fetching of suppressed HTTPS credentials on HTTP origins as the API
+ // is only available on HTTPS origins.
auto form_fetcher = base::MakeUnique<FormFetcherImpl>(
- PasswordStore::FormDigest(*observed_form), client_, false);
+ PasswordStore::FormDigest(*observed_form), client_, false, false);
form_manager_ = base::MakeUnique<CredentialManagerPasswordFormManager>(
client_, GetDriver(), *observed_form, std::move(form), this, nullptr,
std::move(form_fetcher));
« no previous file with comments | « no previous file | components/password_manager/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698