Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2878463003: Introduce SuppressedHTTPSFormFetcher. (Closed)
Patch Set: Polish, test for simultaneous behavior. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/password_manager/core/browser/form_fetcher_impl_unittest.cc ('K') | « components/password_manager/core/browser/form_fetcher_impl_unittest.cc ('k') | components/password_manager/core/browser/suppressed_https_form_fetcher.h » ('j') | components/password_manager/core/browser/suppressed_https_form_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index eb88be67ab7c5ccd1a549ad592c423236fc4d6b3..920a2191e74bcd5e48d47be0f2977e6067eaf6fb 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -239,12 +239,13 @@ PasswordFormManager::PasswordFormManager(
submit_result_(kSubmitResultNotSubmitted),
form_type_(kFormTypeUnspecified),
form_saver_(std::move(form_saver)),
- owned_form_fetcher_(form_fetcher
- ? nullptr
- : base::MakeUnique<FormFetcherImpl>(
- PasswordStore::FormDigest(observed_form),
- client,
- /* should_migrate_http_passwords */ true)),
+ owned_form_fetcher_(
+ form_fetcher ? nullptr
+ : base::MakeUnique<FormFetcherImpl>(
+ PasswordStore::FormDigest(observed_form),
+ client,
+ true /* should_migrate_http_passwords */,
+ false /* should_query_suppressed_https_forms */)),
form_fetcher_(form_fetcher ? form_fetcher : owned_form_fetcher_.get()),
is_main_frame_secure_(client->IsMainFrameSecure()) {
if (owned_form_fetcher_)
« components/password_manager/core/browser/form_fetcher_impl_unittest.cc ('K') | « components/password_manager/core/browser/form_fetcher_impl_unittest.cc ('k') | components/password_manager/core/browser/suppressed_https_form_fetcher.h » ('j') | components/password_manager/core/browser/suppressed_https_form_fetcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698