Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2878413003: Add TestRule for TabModelSelectorObserver tests and convert to JUnit4 (Closed)

Created:
3 years, 7 months ago by the real yoland
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TestRule for TabModelSelectorObserver tests and convert to JUnit4 This CL uses RuleChain to wrap TabModelSelectorObserverTestRule around UiThreadTestRule, since UiThreadTestRule can not run before TabModelSelectorObserverTestRule, which requires to run on non-UI thread For more on JUnit4 migration, please check src/testing/android/docs/junit4.md BUG=640116 Review-Url: https://codereview.chromium.org/2878413003 Cr-Commit-Position: refs/heads/master@{#474084} Committed: https://chromium.googlesource.com/chromium/src/+/708a428ff6d27679a4a50a3ff436f390ff323d85

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address John's comments #

Messages

Total messages: 20 (11 generated)
the real yoland
3 years, 7 months ago (2017-05-15 22:21:57 UTC) #2
mikecase (-- gone --)
non-owner lgtm
3 years, 7 months ago (2017-05-15 22:48:50 UTC) #3
jbudorick
https://codereview.chromium.org/2878413003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java (right): https://codereview.chromium.org/2878413003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java#newcode45 chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java:45: mSelector = mTestRule.getSelector(); Why are we setting this in ...
3 years, 7 months ago (2017-05-15 22:49:15 UTC) #4
the real yoland
https://codereview.chromium.org/2878413003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java (right): https://codereview.chromium.org/2878413003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java#newcode45 chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java:45: mSelector = mTestRule.getSelector(); On 2017/05/15 at 22:49:15, jbudorick wrote: ...
3 years, 7 months ago (2017-05-17 23:32:23 UTC) #5
Ted C
lgtm
3 years, 7 months ago (2017-05-18 14:07:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878413003/20001
3 years, 7 months ago (2017-05-18 17:56:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449046)
3 years, 7 months ago (2017-05-19 00:10:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878413003/20001
3 years, 7 months ago (2017-05-23 20:35:20 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 22:27:01 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/708a428ff6d27679a4a50a3ff436...

Powered by Google App Engine
This is Rietveld 408576698