chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java - Issue 2878403002: Support setting mouse cursor icon in Android N.

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2878403002: Support setting mouse cursor icon in Android N. (Closed)

Patch Set: Override onResolvePointerIcon Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

index 5ba5769404cb0e4f90741c4149aa49211ae74407..a58777b744c42ba18c0d559ef84cc4b0e9c88f63 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -24,6 +24,7 @@ import android.graphics.Rect;

import android.graphics.drawable.ColorDrawable;

import android.graphics.drawable.Drawable;

import android.net.Uri;

+import android.os.Build;

import android.os.Parcelable;

import android.os.SystemClock;

import android.provider.Settings;

@@ -36,6 +37,7 @@ import android.util.Pair;

import android.util.SparseArray;

import android.view.KeyEvent;

import android.view.LayoutInflater;

+import android.view.PointerIcon;

import android.view.View;

import android.view.View.OnClickListener;

import android.view.ViewGroup;

@@ -2293,6 +2295,12 @@ public class LocationBarLayout extends FrameLayout

ViewStub overlayStub = (ViewStub) getRootView().findViewById(omniboxResultsContainerId);

mOmniboxResultsContainer = (ViewGroup) overlayStub.inflate();

+ if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {

+ PointerIcon icon = PointerIcon.getSystemIcon(

+ mOmniboxResultsContainer.getContext(), PointerIcon.TYPE_ARROW);

+ mOmniboxResultsContainer.setPointerIcon(icon);

Ted C 2017/07/21 00:15:25 what is the default icon? why do we need to set a

jaebaek 2017/07/21 10:03:05 In my implementation, onResolvePointerIcon method

Ted C 2017/07/21 18:45:31 Is BottomContainer the only issue? Can that be ma

Is BottomContainer the only issue? Can that be made to wrap_contents? Actually, I'm still confused why partially transparent views give us grief. Looking at the android code link you sent: https://github.com/android/platform_frameworks_base/blob/master/core/java/and... For each child, it checks whether the point is within the view (isTransformedTouchPointInView). When a snackbar is showing, the bottomcontainer has the one view. If you're hovering over the blank area. The code above looks like it should just return null as it should fall into "return super.onResolvePointerIcon" since no view should have returned true for Touch point calculation: https://github.com/android/platform_frameworks_base/blob/master/core/java/and... https://github.com/android/platform_frameworks_base/blob/master/core/java/and... What about the default call in BottomContainer#onResolvePointerIcon doesn't work?

jaebaek 2017/07/24 07:34:11 I changed the layout_height of BottomContainer to

On 2017/07/21 18:45:31, Ted C wrote: > On 2017/07/21 10:03:05, jaebaek wrote: > > On 2017/07/21 00:15:25, Ted C wrote: > > > what is the default icon? why do we need to set anything? > > > > > > I guess this question applies all places. If we don't set anything, is the > > > default icon null? In which case, does it walk up the children to find a > > > non-null icon? > > > > > > That seems like quite the crazy api to me. Does that mean every child in > our > > > code needs to set an arrow to prevent blending up the hierarchy? > > > > In my implementation, onResolvePointerIcon method of > CoordinatorLayoutForPointer > > skips children that return null in onResolvePointerIcon. The reason behind > this > > is because of partially transparent views. > > > > When SnackBar is shown, BottomContainer is not invisible but transparent > except > > the part for SnackBar. In the case, the pointer icon for the transparent part > > must be the same with the one of CompositorViewHolder, while the one of > SnackBar > > is not. If onResolvePointerIcon of CoordinatorLayoutForPointer only checks > > visibility (without null check), it chooses pointer icon of BottomContainer > but > > not the one for CompositorViewHolder. Thus, point icon is always default > (i.e., > > null). > > > > To solve this, I add null check in onResolvePointerIcon of > > CoordinatorLayoutForPointer. Because of the null check, All its children must > > return non-null in onResolvePointerIcon, when they are not transparent. > > Is BottomContainer the only issue? Can that be made to wrap_contents? > > Actually, I'm still confused why partially transparent views give us grief. > > Looking at the android code link you sent: > https://github.com/android/platform_frameworks_base/blob/master/core/java/and... > > For each child, it checks whether the point is within the view > (isTransformedTouchPointInView). When a snackbar is showing, > the bottomcontainer has the one view. If you're hovering over > the blank area. The code above looks like it should just return > null as it should fall into "return super.onResolvePointerIcon" > since no view should have returned true for > > Touch point calculation: > https://github.com/android/platform_frameworks_base/blob/master/core/java/and... > https://github.com/android/platform_frameworks_base/blob/master/core/java/and... > > What about the default call in BottomContainer#onResolvePointerIcon > doesn't work?

I changed the layout_height of BottomContainer to wrap_content.

+ }

}

private void updateOmniboxResultsContainer() {