Index: chrome/android/java/res/layout/main.xml |
diff --git a/chrome/android/java/res/layout/main.xml b/chrome/android/java/res/layout/main.xml |
index 4d5402a867869943eb9cbe19d7be5a96224e2d81..6884914c5a72f7a8e3bf6b97191a859c48ec38df 100644 |
--- a/chrome/android/java/res/layout/main.xml |
+++ b/chrome/android/java/res/layout/main.xml |
@@ -23,12 +23,12 @@ |
<FrameLayout |
android:id="@+id/overview_list_layout_holder" |
android:layout_width="match_parent" |
- android:layout_height="match_parent" /> |
+ android:layout_height="wrap_content" /> |
Ted C
2017/07/18 16:41:18
I'm pretty sure this needs to be match_parent. Th
jaebaek
2017/07/19 01:18:53
If we must keep it as match_parent, there is no ch
mdjones
2017/07/19 18:40:50
This will need to remain match parent. That being
jaebaek
2017/07/20 14:16:30
Simply checking whether a view's visibility is 'go
|
<org.chromium.chrome.browser.snackbar.BottomContainer |
android:id="@+id/bottom_container" |
android:layout_width="match_parent" |
- android:layout_height="match_parent" |
+ android:layout_height="wrap_content" |
android:layout_gravity="start|bottom"> |
<HorizontalScrollView |
@@ -56,7 +56,7 @@ |
<org.chromium.chrome.browser.widget.FadingBackgroundView |
android:id="@+id/fading_focus_target" |
android:layout_width="match_parent" |
- android:layout_height="match_parent" |
+ android:layout_height="0dp" |
Ted C
2017/07/18 16:41:18
as mentioned in the other file, this doesn't seem
jaebaek
2017/07/19 01:18:53
The reason behind this is because onResolvePointer
mdjones
2017/07/19 18:40:50
Does this view not return null for onResolvePointe
|
android:layout_marginTop="@dimen/tab_strip_height" |
android:background="@color/omnibox_focused_fading_background_color" |
android:visibility="gone" /> |
@@ -92,7 +92,7 @@ |
<FrameLayout |
android:id="@+id/bottom_sheet_snackbar_container" |
android:layout_width="match_parent" |
- android:layout_height="match_parent" |
+ android:layout_height="wrap_content" |
android:layout_gravity="start|bottom" |
android:layout_marginTop="@dimen/bottom_nav_height_inverse" /> |
@@ -102,7 +102,6 @@ |
android:layout="@layout/empty_background_view_tablet" |
android:layout_width="match_parent" |
android:layout_height="match_parent" /> |
- |
</android.support.design.widget.CoordinatorLayout> |
</LinearLayout> |