Support setting mouse cursor icon in Android N.

ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.ui.base;
 
 import android.annotation.TargetApi;
 import android.content.ClipData;
 import android.graphics.Bitmap;
 import android.os.Build;
+import android.view.PointerIcon;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout.LayoutParams;
 import android.widget.ImageView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
 
 /**
@@ skipping 71 matching lines @@
         if (containerView == null) return false;
 
         ImageView imageView = new ImageView(containerView.getContext());
         imageView.setImageBitmap(shadowImage);
         imageView.layout(0, 0, shadowImage.getWidth(), shadowImage.getHeight());
 
         return containerView.startDragAndDrop(ClipData.newPlainText(null, text),
                 new View.DragShadowBuilder(imageView), null, View.DRAG_FLAG_GLOBAL);
     }
 
+    @CalledByNative
+    private void onCursorChangedToCustom(Bitmap customCursorBitmap, int hotspotX, int hotspotY) {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
+            getContainerView().getRootView().setPointerIcon(
+                    PointerIcon.create(customCursorBitmap, hotspotX, hotspotY));
+        }
+    }
+
+    @CalledByNative
+    public void onCursorChanged(int cursorType) {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {

[aelias_OOO_until_Jul13, 2017/05/17 04:47:15]

"if ( < N ) return;" to reduce indentation

[Jinsuk Kim, 2017/05/17 04:49:50]

Do early return to avoid too long if.

if (INT < N) return;

[jaebaek, 2017/05/18 01:44:28]

Done.

[jaebaek, 2017/05/18 01:44:29]

Done.

+            ViewGroup containerView = getContainerView();

[Jinsuk Kim, 2017/05/17 04:49:50]

Define variables for the root view and the context to make the switch statement
less verbose.

[jaebaek, 2017/05/18 01:44:29]

Done.

+            switch (cursorType) {
+                case CursorType.NULL:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_NULL));

[aelias_OOO_until_Jul13, 2017/05/17 04:47:15]

You can avoid some boilerplate duplication here by just assigning the
PointerIcon type to an integer in the switch statement, and call the get/set at
the end of the method.

[jaebaek, 2017/05/18 01:44:29]

Done.

+                    break;
+                case CursorType.ARROW:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_ARROW));
+                    break;
+                case CursorType.CONTEXT_MENU:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_CONTEXT_MENU));
+                    break;
+                case CursorType.HAND:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_HAND));
+                    break;
+                case CursorType.HELP:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_HELP));
+                    break;
+                case CursorType.WAIT:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_WAIT));
+                    break;
+                case CursorType.CELL:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_CELL));
+                    break;
+                case CursorType.CROSSHAIR:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_CROSSHAIR));
+                    break;
+                case CursorType.TEXT:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_TEXT));
+                    break;
+                case CursorType.VERTICAL_TEXT:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_VERTICAL_TEXT));
+                    break;
+                case CursorType.ALIAS:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_ALIAS));
+                    break;
+                case CursorType.COPY:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_COPY));
+                    break;
+                case CursorType.NO_DROP:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_NO_DROP));
+                    break;
+                case CursorType.ALL_SCROLL:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_ALL_SCROLL));
+                    break;
+                case CursorType.HORIZONTAL_DOUBLE_ARROW:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_HORIZONTAL_DOUBLE_ARROW));
+                    break;
+                case CursorType.VERTICAL_DOUBLE_ARROW:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_VERTICAL_DOUBLE_ARROW));
+                    break;
+                case CursorType.TOP_RIGHT_DIAGONAL_DOUBLE_ARROW:
+                    containerView.getRootView().setPointerIcon(
+                            PointerIcon.getSystemIcon(containerView.getContext(),
+                                    PointerIcon.TYPE_TOP_RIGHT_DIAGONAL_DOUBLE_ARROW));
+                    break;
+                case CursorType.TOP_LEFT_DIAGONAL_DOUBLE_ARROW:
+                    containerView.getRootView().setPointerIcon(
+                            PointerIcon.getSystemIcon(containerView.getContext(),
+                                    PointerIcon.TYPE_TOP_LEFT_DIAGONAL_DOUBLE_ARROW));
+                    break;
+                case CursorType.ZOOM_IN:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_ZOOM_IN));
+                    break;
+                case CursorType.ZOOM_OUT:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_ZOOM_OUT));
+                    break;
+                case CursorType.GRAB:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_GRAB));
+                    break;
+                case CursorType.GRABBING:
+                    containerView.getRootView().setPointerIcon(PointerIcon.getSystemIcon(
+                            containerView.getContext(), PointerIcon.TYPE_GRABBING));
+                    break;
+                default:

[aelias_OOO_until_Jul13, 2017/05/17 04:47:15]

Please exhaustively list all remaining WebCursorInfo types instead of using
"default:".  This will help keep this file synchronized with the C++ header.

[jaebaek, 2017/05/18 01:44:29]

I listed all WebCursorInfo types and default for exceptions.

+                    break;
+            }
+        }
+    }
+
     /**
      * Called whenever the background color of the page changes as notified by Blink.
      * @param color The new ARGB color of the page background.
      */
     @CalledByNative
     public void onBackgroundColorChanged(int color) {}
 
     /**
      * Notify the client of the position of the top controls.
      * @param topControlsOffsetY The Y offset of the top controls in physical pixels.
@@ skipping 42 matching lines @@
                 return this;
             }
 
             @Override
             public ViewGroup getContainerView() {
                 return mContainerView;
             }
         }.init(containerView);
     }
 }