Support setting mouse cursor icon in Android N.

ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.ui.base;
 
 import android.annotation.TargetApi;
 import android.content.ClipData;
 import android.graphics.Bitmap;
 import android.os.Build;
+import android.view.PointerIcon;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout.LayoutParams;
 import android.widget.ImageView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
+import org.chromium.blink_public.web.WebCursorInfoType;
 
 /**
  * Class to acquire, position, and remove anchor views from the implementing View.
  */
 @JNINamespace("ui")
 public abstract class ViewAndroidDelegate {
     /**
      * @return An anchor view that can be used to anchor decoration views like Autofill popup.
      */
     @CalledByNative
@@ skipping 63 matching lines @@
         if (containerView == null) return false;
 
         ImageView imageView = new ImageView(containerView.getContext());
         imageView.setImageBitmap(shadowImage);
         imageView.layout(0, 0, shadowImage.getWidth(), shadowImage.getHeight());
 
         return containerView.startDragAndDrop(ClipData.newPlainText(null, text),
                 new View.DragShadowBuilder(imageView), null, View.DRAG_FLAG_GLOBAL);
     }
 
+    @CalledByNative
+    private void onCursorChangedToCustom(Bitmap customCursorBitmap, int hotspotX, int hotspotY) {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
+            getContainerView().getRootView().setPointerIcon(

[boliu, 2017/05/24 18:24:07]

same issue here

[jaebaek, 2017/05/29 12:40:03]

Done.

+                    PointerIcon.create(customCursorBitmap, hotspotX, hotspotY));
+        }
+    }
+
+    @CalledByNative
+    public void onCursorChanged(int cursorType) {

[boliu, 2017/05/24 18:24:07]

private

[jaebaek, 2017/05/29 12:40:03]

Done.

+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.N) return;
+
+        int pointerIconType = PointerIcon.TYPE_ARROW;
+        switch (cursorType) {
+            case WebCursorInfoType.TYPE_NONE:
+                pointerIconType = PointerIcon.TYPE_NULL;
+                break;
+            case WebCursorInfoType.TYPE_POINTER:
+                pointerIconType = PointerIcon.TYPE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_CONTEXT_MENU:
+                pointerIconType = PointerIcon.TYPE_CONTEXT_MENU;
+                break;
+            case WebCursorInfoType.TYPE_HAND:
+                pointerIconType = PointerIcon.TYPE_HAND;
+                break;
+            case WebCursorInfoType.TYPE_HELP:
+                pointerIconType = PointerIcon.TYPE_HELP;
+                break;
+            case WebCursorInfoType.TYPE_WAIT:
+                pointerIconType = PointerIcon.TYPE_WAIT;
+                break;
+            case WebCursorInfoType.TYPE_CELL:
+                pointerIconType = PointerIcon.TYPE_CELL;
+                break;
+            case WebCursorInfoType.TYPE_CROSS:
+                pointerIconType = PointerIcon.TYPE_CROSSHAIR;
+                break;
+            case WebCursorInfoType.TYPE_I_BEAM:
+                pointerIconType = PointerIcon.TYPE_TEXT;
+                break;
+            case WebCursorInfoType.TYPE_VERTICAL_TEXT:
+                pointerIconType = PointerIcon.TYPE_VERTICAL_TEXT;
+                break;
+            case WebCursorInfoType.TYPE_ALIAS:
+                pointerIconType = PointerIcon.TYPE_ALIAS;
+                break;
+            case WebCursorInfoType.TYPE_COPY:
+                pointerIconType = PointerIcon.TYPE_COPY;
+                break;
+            case WebCursorInfoType.TYPE_NO_DROP:
+                pointerIconType = PointerIcon.TYPE_NO_DROP;
+                break;
+            case WebCursorInfoType.TYPE_COLUMN_RESIZE:
+                pointerIconType = PointerIcon.TYPE_HORIZONTAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_ROW_RESIZE:
+                pointerIconType = PointerIcon.TYPE_VERTICAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_NORTH_EAST_SOUTH_WEST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_TOP_RIGHT_DIAGONAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_NORTH_WEST_SOUTH_EAST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_TOP_LEFT_DIAGONAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_ZOOM_IN:
+                pointerIconType = PointerIcon.TYPE_ZOOM_IN;
+                break;
+            case WebCursorInfoType.TYPE_ZOOM_OUT:
+                pointerIconType = PointerIcon.TYPE_ZOOM_OUT;
+                break;
+            case WebCursorInfoType.TYPE_GRAB:
+                pointerIconType = PointerIcon.TYPE_GRAB;
+                break;
+            case WebCursorInfoType.TYPE_GRABBING:
+                pointerIconType = PointerIcon.TYPE_GRABBING;
+                break;
+            // TODO(jaebaek): set types correctly
+            // after fixing http://crbug.com/584424.
+            case WebCursorInfoType.TYPE_EAST_WEST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_HORIZONTAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_NORTH_SOUTH_RESIZE:
+                pointerIconType = PointerIcon.TYPE_VERTICAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_EAST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_HORIZONTAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_NORTH_RESIZE:
+                pointerIconType = PointerIcon.TYPE_VERTICAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_NORTH_EAST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_TOP_RIGHT_DIAGONAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_NORTH_WEST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_TOP_LEFT_DIAGONAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_SOUTH_RESIZE:
+                pointerIconType = PointerIcon.TYPE_VERTICAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_SOUTH_EAST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_TOP_LEFT_DIAGONAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_SOUTH_WEST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_TOP_RIGHT_DIAGONAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_WEST_RESIZE:
+                pointerIconType = PointerIcon.TYPE_HORIZONTAL_DOUBLE_ARROW;
+                break;
+            case WebCursorInfoType.TYPE_PROGRESS:
+                pointerIconType = PointerIcon.TYPE_WAIT;
+                break;
+            case WebCursorInfoType.TYPE_NOT_ALLOWED:
+                pointerIconType = PointerIcon.TYPE_NO_DROP;
+                break;
+            case WebCursorInfoType.TYPE_EAST_PANNING:
+            case WebCursorInfoType.TYPE_NORTH_PANNING:
+            case WebCursorInfoType.TYPE_NORTH_EAST_PANNING:
+            case WebCursorInfoType.TYPE_NORTH_WEST_PANNING:
+            case WebCursorInfoType.TYPE_SOUTH_PANNING:
+            case WebCursorInfoType.TYPE_SOUTH_EAST_PANNING:
+            case WebCursorInfoType.TYPE_SOUTH_WEST_PANNING:
+            case WebCursorInfoType.TYPE_WEST_PANNING:
+                assert false : "These pointer icon types are not supported";

[aelias_OOO_until_Jul13, 2017/05/24 19:03:56]

As Java asserts are not stripped even in release builds, asserting is a
unnecessarily heavyweight for these in case Blink ever sends them (probably in
the context of setting --enable-blink-features=MiddleClickAutoscroll ).  As
we're going with the approach of mapping to close-enough cursors, I suggest
mapping them to TYPE_ALL_SCROLL as well.

[boliu, 2017/05/24 19:14:02]

Actually, agrieve made java asserts work just like DCHECK now. Enabled on debug
builds everywhere, and stripped out of release builds. It was some black magic
that involved modifying byte code after compilation, but it works..

[jaebaek, 2017/05/29 12:40:03]

Ok, then I will keep this assert. Thank you for the good information.

+                break;
+            case WebCursorInfoType.TYPE_MOVE:

[aelias_OOO_until_Jul13, 2017/05/24 19:03:56]

Please map MOVE and MIDDLE_PANNING to "TYPE_ALL_SCROLL" and delete the ui/base
code.  According to
https://developer.android.com/reference/android/R.attr.html#pointerIcon ,
"ALL_SCROLL" is the four-way-arrow PNG which I've observed is used for these two
types on ChromeOS.

[jaebaek, 2017/05/29 12:40:03]

Done.

+            case WebCursorInfoType.TYPE_MIDDLE_PANNING:
+            case WebCursorInfoType.TYPE_CUSTOM:
+                assert false : "onCursorChangedToCustom must be called instead";
+                break;
+        }
+        updatePointerIcon(pointerIconType);
+    }
+
+    public void updatePointerIcon(int type) {

[boliu, 2017/05/24 18:24:07]

methods that embedders override should be no-op

document what int type is

[jaebaek, 2017/05/29 12:40:03]

Done.

+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
+            ViewGroup containerView = getContainerView();
+            containerView.getRootView().setPointerIcon(
+                    PointerIcon.getSystemIcon(containerView.getContext(), type));
+        }
+    }
+
     /**
      * Called whenever the background color of the page changes as notified by Blink.
      * @param color The new ARGB color of the page background.
      */
     @CalledByNative
     public void onBackgroundColorChanged(int color) {}
 
     /**
      * Notify the client of the position of the top controls.
      * @param topControlsOffsetY The Y offset of the top controls in physical pixels.
@@ skipping 42 matching lines @@
                 return this;
             }
 
             @Override
             public ViewGroup getContainerView() {
                 return mContainerView;
             }
         }.init(containerView);
     }
 }