Issue 2878393002: [kernel] Fix call to NameIndex(NULL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2878393002: [kernel] Fix call to NameIndex(NULL) (Closed)

Created:
3 years, 7 months ago by jensj

Modified:
3 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[kernel] Fix call to NameIndex(NULL) Previous commit had 3 instances of "NameIndex(NULL)" which workes locally. Some of the build bots complain about "implicit conversion of NULL constant to 'int'". This should fix that. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/73d3aedc6dc6a70482edc688676c0f72709e0314

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/vm/kernel_binary_flowgraph.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

jensj

3 years, 7 months ago (2017-05-15 07:45:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
73d3aedc6dc6a70482edc688676c0f72709e0314 (presubmit successful).