Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2878383003: Fix command line args validation for platform compilation with fasta (Closed)

Created:
3 years, 7 months ago by Dmitry Stefantsov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix command line args validation for platform compilation with fasta This commit is to adjust command line arguments validation for platform compilation with fasta according to the interface changes made in db331244d018ceaf7a35995f1ad4cac5f2ad0a4f. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/1de8e38121d2f8282a45f0feb2035bf9a0191ddf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove the comment, fix the error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dmitry Stefantsov
3 years, 7 months ago (2017-05-15 09:48:15 UTC) #2
ahe
lgtm https://codereview.chromium.org/2878383003/diff/1/pkg/front_end/lib/src/fasta/compiler_command_line.dart File pkg/front_end/lib/src/fasta/compiler_command_line.dart (right): https://codereview.chromium.org/2878383003/diff/1/pkg/front_end/lib/src/fasta/compiler_command_line.dart#newcode56 pkg/front_end/lib/src/fasta/compiler_command_line.dart:56: return argumentError(usage, "Expected two arguments."); Consider removing the ...
3 years, 7 months ago (2017-05-15 11:02:01 UTC) #3
Dmitry Stefantsov
https://codereview.chromium.org/2878383003/diff/1/pkg/front_end/lib/src/fasta/compiler_command_line.dart File pkg/front_end/lib/src/fasta/compiler_command_line.dart (right): https://codereview.chromium.org/2878383003/diff/1/pkg/front_end/lib/src/fasta/compiler_command_line.dart#newcode56 pkg/front_end/lib/src/fasta/compiler_command_line.dart:56: return argumentError(usage, "Expected two arguments."); On 2017/05/15 11:02:01, ahe ...
3 years, 7 months ago (2017-05-15 11:07:04 UTC) #4
Dmitry Stefantsov
Committed patchset #2 (id:20001) manually as 1de8e38121d2f8282a45f0feb2035bf9a0191ddf (presubmit successful).
3 years, 7 months ago (2017-05-15 11:08:32 UTC) #6
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-05-15 16:39:43 UTC) #8
Message was sent while issue was closed.
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698