Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java |
| index c9263dcc6f31c63d15b4069654fc4e4834c588a7..9d5a2d6e8487e8176110672a8fd2e7cf16ad9cf5 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java |
| @@ -37,6 +37,10 @@ class TranslateCompactInfoBar extends InfoBar |
| private long mNativeTranslateInfoBarPtr; |
| private TranslateTabLayout mTabLayout; |
| + // Metric to track the total number of translations in a page, including reverts to original. |
| + private int mTotalTranslationCount = 0; |
|
mdjones
2017/05/15 16:00:30
Is this only supposed to count the number of trans
ramyasharma
2017/05/16 05:40:09
Yes, it counts the number of times the page was tr
|
| + |
| + // Histogram names for logging metrics. |
| private static final String INFOBAR_HISTOGRAM_TRANSLATE_LANGUAGE = |
| "Translate.CompactInfobar.Language.Translate"; |
| private static final String INFOBAR_HISTOGRAM_MORE_LANGUAGES_LANGUAGE = |
| @@ -48,6 +52,8 @@ class TranslateCompactInfoBar extends InfoBar |
| private static final String INFOBAR_HISTOGRAM_NEVER_TRANSLATE_LANGUAGE = |
| "Translate.CompactInfobar.Language.NeverTranslate"; |
| private static final String INFOBAR_HISTOGRAM = "Translate.CompactInfobar.Event"; |
| + private static final String INFOBAR_HISTOGRAM_TRANSLATION_COUNT = |
| + "Translate.CompactInfobar.Count"; |
| /** |
| * This is used to back a UMA histogram, so it should be treated as |
| @@ -73,7 +79,9 @@ class TranslateCompactInfoBar extends InfoBar |
| private static final int INFOBAR_SNACKBAR_CANCEL_ALWAYS = 16; |
| private static final int INFOBAR_SNACKBAR_CANCEL_NEVER_SITE = 17; |
| private static final int INFOBAR_SNACKBAR_CANCEL_NEVER = 18; |
| - private static final int INFOBAR_HISTOGRAM_BOUNDARY = 19; |
| + private static final int INFOBAR_ALWAYS_TRANSLATE_UNDO = 19; |
| + private static final int INFOBAR_CLOSE = 20; |
| + private static final int INFOBAR_HISTOGRAM_BOUNDARY = 21; |
| // Need 2 instances of TranslateMenuHelper to prevent a race condition bug which happens when |
| // showing language menu after dismissing overflow menu. |
| @@ -202,6 +210,7 @@ class TranslateCompactInfoBar extends InfoBar |
| @CalledByNative |
| private void onPageTranslated(int errorType) { |
| + mTotalTranslationCount++; |
| if (mTabLayout != null) { |
| mTabLayout.hideProgressBar(); |
| if (errorType != 0) { |
| @@ -237,8 +246,12 @@ class TranslateCompactInfoBar extends InfoBar |
| @Override |
| public void onCloseButtonClicked() { |
| if (!mUserInteracted) { |
| + recordInfobarAction(INFOBAR_DECLINE); |
| onButtonClicked(ActionType.CANCEL); |
| } |
| + recordInfobarAction(INFOBAR_CLOSE); |
| + RecordHistogram.recordCountHistogram( |
| + INFOBAR_HISTOGRAM_TRANSLATION_COUNT, mTotalTranslationCount); |
| super.onCloseButtonClicked(); |
| } |
| @@ -276,16 +289,17 @@ class TranslateCompactInfoBar extends InfoBar |
| mLanguageMenuHelper.show(TranslateMenu.MENU_TARGET_LANGUAGE); |
| return; |
| case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE: |
| - recordInfobarAction(INFOBAR_ALWAYS_TRANSLATE); |
| - recordInfobarLanguageData( |
| - INFOBAR_HISTOGRAM_ALWAYS_TRANSLATE_LANGUAGE, mOptions.sourceLanguageCode()); |
| // Only show snackbar when "Always Translate" is enabled. |
| if (!mOptions.alwaysTranslateLanguageState()) { |
| + recordInfobarAction(INFOBAR_ALWAYS_TRANSLATE); |
| + recordInfobarLanguageData(INFOBAR_HISTOGRAM_ALWAYS_TRANSLATE_LANGUAGE, |
| + mOptions.sourceLanguageCode()); |
| createAndShowSnackbar( |
| getContext().getString(R.string.translate_snackbar_always_translate, |
| mOptions.sourceLanguageName(), mOptions.targetLanguageName()), |
| Snackbar.UMA_TRANSLATE_ALWAYS, itemId); |
| } else { |
| + recordInfobarAction(INFOBAR_ALWAYS_TRANSLATE_UNDO); |
| handleTranslateOptionPostSnackbar(itemId); |
| } |
| return; |