Handlify PropertyCell::SetValueInferType and friends.

Handlify PropertyCell::SetValueInferType and friends.

This finally gets rid of the pesky trampoline in SetValueInferType and
enforces the layering between PropertyCell and Heap. It requires full
handlification of NewGlobalObject as well, which is only used when the
snapshot is created at compile-time.

R=rossberg@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=17297

[rossberg, 2013-10-21 12:16:35]

lgtm

https://codereview.chromium.org/28783002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/28783002/diff/1/src/objects.cc#newcode16322
src/objects.cc:16322: Type* new_type = UpdateType(cell, value);
Nit: could inline this

https://codereview.chromium.org/28783002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/28783002/diff/1/src/objects.h#newcode9199
src/objects.h:9199: static Type* UpdateType(Handle<PropertyCell> cell,
Maybe it would be clearer to call this UpdatedType

[Michael Starzinger, 2013-10-21 12:49:44]

https://codereview.chromium.org/28783002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/28783002/diff/1/src/objects.cc#newcode16322
src/objects.cc:16322: Type* new_type = UpdateType(cell, value);
On 2013/10/21 12:16:35, rossberg wrote:
> Nit: could inline this

Nope. This cannot be inlined, as "cell" is a handle and UpdateType() can cause a
GC, this would be unsafe and GCMole would complain. This would be clearer if
UpdateType() would return a handle instead of a raw pointer. :)

https://codereview.chromium.org/28783002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/28783002/diff/1/src/objects.h#newcode9199
src/objects.h:9199: static Type* UpdateType(Handle<PropertyCell> cell,
On 2013/10/21 12:16:35, rossberg wrote:
> Maybe it would be clearer to call this UpdatedType

Done.

[Michael Starzinger, 2013-10-21 13:55:39]

Committed patchset #2 manually as r17297 (presubmit successful).