Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2878233002: media: add ArcCamera3Service Mojo service (Closed)

Created:
3 years, 7 months ago by jcliang
Modified:
3 years, 6 months ago
Reviewers:
wuchengli, chfremer
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, chfremer+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, oshima+watch_chromium.org, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: add ArcCamera3Service Mojo service The ArcCamera3Service Mojo service serves as a proxy to establish the connections between the camera clients (i.e. VideoCaptureDevice in Chrome and cameraserver process in ARC++ container) and the camera HALv3 adapter process in Chrome OS. BUG=b:32690003 TEST=Make sure camera preview works in hangout. TEST=unit tests

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase on latest patch set of issue 2837273004 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -68 lines) Patch
M media/capture/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A media/capture/video/chromeos/arc_camera3_service.h View 1 1 chunk +106 lines, -0 lines 0 comments Download
A media/capture/video/chromeos/arc_camera3_service.cc View 1 1 chunk +343 lines, -0 lines 0 comments Download
M media/capture/video/chromeos/camera_device_delegate_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/chromeos/camera_hal_delegate.h View 1 3 chunks +22 lines, -4 lines 0 comments Download
M media/capture/video/chromeos/camera_hal_delegate.cc View 1 8 chunks +44 lines, -61 lines 0 comments Download
M media/capture/video/chromeos/camera_hal_delegate_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/chromeos/mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A media/capture/video/chromeos/mojo/arc_camera3_service.mojom View 1 1 chunk +21 lines, -0 lines 0 comments Download
M media/capture/video/chromeos/video_capture_device_factory_chromeos.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/chromeos/video_capture_device_factory_chromeos.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
jcliang
3 years, 7 months ago (2017-05-18 02:45:16 UTC) #2
chfremer
Just a quick drive-by question. https://codereview.chromium.org/2878233002/diff/1/media/capture/video/video_capture_device_unittest.cc File media/capture/video/video_capture_device_unittest.cc (right): https://codereview.chromium.org/2878233002/diff/1/media/capture/video/video_capture_device_unittest.cc#newcode221 media/capture/video/video_capture_device_unittest.cc:221: class VideoCaptureDeviceTestEnvironment final : ...
3 years, 7 months ago (2017-05-18 17:24:39 UTC) #4
jcliang
3 years, 6 months ago (2017-06-20 02:35:54 UTC) #7
Message was sent while issue was closed.
Moved to gerrit: https://chromium-review.googlesource.com/c/540956/

Powered by Google App Engine
This is Rietveld 408576698