Fixed some edit commands for OOPIF-<webivew> (Mac)

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import <Carbon/Carbon.h>
 #import <objc/runtime.h>
 #include <OpenGL/gl.h>
 #include <QuartzCore/QuartzCore.h>
@@ skipping 705 matching lines @@
   // We obtain the TextSelection from focused RWH which is obtained from the
   // frame tree. BrowserPlugin-based guests' RWH is not part of the frame tree
   // and the focused RWH will be that of the embedder which is incorrect. In
   // this case we should use TextSelection for |this| since RWHV for guest
   // forwards text selection information to its platform view.
   return is_guest_view_hack_ ? this : GetFocusedWidget()
                                           ? GetFocusedWidget()->GetView()
                                           : nullptr;
 }
 
+RenderWidgetHostDelegate*
+RenderWidgetHostViewMac::GetFocusedRenderWidgetHostDelegate() {
+  if (auto* focused_widget = GetFocusedWidget())
+    return focused_widget->delegate();
+  return render_widget_host_->delegate();

[EhsanK, 2017/05/16 04:34:32]

We were not checking |render_widget_host_ != nullptr| before so I am not doing
it either. 

That being said, there are cases where |render_widget_host_| could be nullptr,
e.g., RenderWidgetHostViewMac::ForwardMouseEvent checks for that. I believe for
popups it might be possible that |render_widget_host_| is null when mouse input
arrives. But for popups we do not need edit commands so (I guess) we are (and
have been) safe here.

[Charlie Reis, 2017/05/16 16:24:56]

Sounds fine.  Thanks!

+}
+
 void RenderWidgetHostViewMac::UpdateBackingStoreProperties() {
   if (!render_widget_host_)
     return;
   render_widget_host_->NotifyScreenInfoChanged();
 }
 
 RenderWidgetHost* RenderWidgetHostViewMac::GetRenderWidgetHost() const {
   return render_widget_host_;
 }
 
@@ skipping 2604 matching lines @@
     web_contents->Undo();
 }
 
 - (void)redo:(id)sender {
   WebContents* web_contents = renderWidgetHostView_->GetWebContents();
   if (web_contents)
     web_contents->Redo();
 }
 
 - (void)cut:(id)sender {
-  content::RenderWidgetHostDelegate* render_widget_host_delegate =
-      renderWidgetHostView_->render_widget_host_->delegate();
-  if (render_widget_host_delegate)
-    render_widget_host_delegate->Cut();
+  if (auto* delegate =
+          renderWidgetHostView_->GetFocusedRenderWidgetHostDelegate()) {
+    delegate->Cut();
+  }
 }
 
 - (void)copy:(id)sender {
-  content::RenderWidgetHostDelegate* render_widget_host_delegate =
-      renderWidgetHostView_->render_widget_host_->delegate();
-  if (render_widget_host_delegate)
-    render_widget_host_delegate->Copy();
+  if (auto* delegate =
+          renderWidgetHostView_->GetFocusedRenderWidgetHostDelegate()) {
+    delegate->Copy();
+  }
 }
 
 - (void)copyToFindPboard:(id)sender {
   WebContents* web_contents = renderWidgetHostView_->GetWebContents();
   if (web_contents)
     web_contents->CopyToFindPboard();
 }
 
 - (void)paste:(id)sender {
-  content::RenderWidgetHostDelegate* render_widget_host_delegate =
-      renderWidgetHostView_->render_widget_host_->delegate();
-  if (render_widget_host_delegate)
-    render_widget_host_delegate->Paste();
+  if (auto* delegate =
+          renderWidgetHostView_->GetFocusedRenderWidgetHostDelegate()) {
+    delegate->Paste();
+  }
 }
 
 - (void)pasteAndMatchStyle:(id)sender {
   WebContents* web_contents = renderWidgetHostView_->GetWebContents();
   if (web_contents)
     web_contents->PasteAndMatchStyle();
 }
 
 - (void)selectAll:(id)sender {
   // editCommand_helper_ adds implementations for most NSResponder methods
   // dynamically. But the renderer side only sends selection results back to
   // the browser if they were triggered by a keyboard event or went through
   // one of the Select methods on RWH. Since selectAll: is called from the
   // menu handler, neither is true.
   // Explicitly call SelectAll() here to make sure the renderer returns
   // selection results.
-  content::RenderWidgetHostDelegate* render_widget_host_delegate =
-      renderWidgetHostView_->render_widget_host_->delegate();
-  if (render_widget_host_delegate)
-    render_widget_host_delegate->SelectAll();
+  if (auto* delegate =
+          renderWidgetHostView_->GetFocusedRenderWidgetHostDelegate()) {
+    delegate->SelectAll();
+  }
 }
 
 - (void)startSpeaking:(id)sender {
   GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->SpeakSelection();
 }
 
 - (void)stopSpeaking:(id)sender {
   GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->StopSpeaking();
 }
 
@@ skipping 99 matching lines @@
 
 // "-webkit-app-region: drag | no-drag" is implemented on Mac by excluding
 // regions that are not draggable. (See ControlRegionView in
 // native_app_window_cocoa.mm). This requires the render host view to be
 // draggable by default.
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
 
 @end