mus: Embedder can request and observe BeginFrame for embedded client.

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <set>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 637 matching lines @@
 void RenderWidgetHostViewAura::SetNeedsBeginFrames(bool needs_begin_frames) {
   needs_begin_frames_ = needs_begin_frames;
   UpdateNeedsBeginFramesInternal();
 }
 
 void RenderWidgetHostViewAura::OnSetNeedsFlushInput() {
   needs_flush_input_ = true;
   UpdateNeedsBeginFramesInternal();
 }
 
-void RenderWidgetHostViewAura::OnBeginFrame(
-    const cc::BeginFrameArgs& args) {
+void RenderWidgetHostViewAura::OnBeginFrame(const cc::BeginFrameArgs& args) {
   needs_flush_input_ = false;
   host_->FlushInput();
   UpdateNeedsBeginFramesInternal();
-  host_->Send(new ViewMsg_BeginFrame(host_->GetRoutingID(), args));
+  if (!IsMus())
+    host_->Send(new ViewMsg_BeginFrame(host_->GetRoutingID(), args));
 }
 
 RenderFrameHostImpl* RenderWidgetHostViewAura::GetFocusedFrame() {
   RenderViewHost* rvh = RenderViewHost::From(host_);
   if (!rvh)
     return nullptr;
   FrameTreeNode* focused_frame =
       rvh->GetDelegate()->GetFrameTree()->GetFocusedFrame();
   if (!focused_frame)
     return nullptr;
@@ skipping 1706 matching lines @@
 
 void RenderWidgetHostViewAura::SetPopupChild(
     RenderWidgetHostViewAura* popup_child_host_view) {
   popup_child_host_view_ = popup_child_host_view;
   event_handler_->SetPopupChild(
       popup_child_host_view,
       popup_child_host_view ? popup_child_host_view->event_handler() : nullptr);
 }
 
 void RenderWidgetHostViewAura::UpdateNeedsBeginFramesInternal() {
-  if (!delegated_frame_host_)
+  bool needs_begin_frames = needs_begin_frames_ || needs_flush_input_;
+  if (delegated_frame_host_) {
+    delegated_frame_host_->SetNeedsBeginFrames(needs_begin_frames);
     return;
-  delegated_frame_host_->SetNeedsBeginFrames(needs_begin_frames_ ||
-                                             needs_flush_input_);
+  }
+  if (!IsMus())
+    return;
+  window()->SetNeedsBeginFrames(
+      needs_begin_frames_ || needs_flush_input_,
+      base::Bind(&RenderWidgetHostViewAura::OnBeginFrame,
+                 weak_ptr_factory_.GetWeakPtr(), cc::BeginFrameArgs()));

[Fady Samuel, 2017/05/12 22:42:55]

Maybe propagate the BeginFrameArgs from viz?

[sadrul, 2017/05/13 03:01:38]

I considered doing that. The reasons I didn't are (1) it's not going to be used,
yet, anyway, and (2) it's not clear to me whether this could include useful
information for this observer anyway.

 }
 
 }  // namespace content