Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2878103002: Remove .iml files from the repository. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove .iml files from the repository. These files weren't providing enough benefit compared to the confusion they were causing by showing up frequently in diffs. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f4d3f6cf458810ef58735242e483901956872e5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -233 lines) Patch
D pkg/analysis_server/analysis_server.iml View 1 chunk +0 lines, -62 lines 0 comments Download
D pkg/analyzer/analyzer.iml View 1 chunk +0 lines, -47 lines 0 comments Download
D pkg/analyzer_cli/analyzer_cli.iml View 1 chunk +0 lines, -53 lines 0 comments Download
D pkg/analyzer_plugin/analyzer_plugin.iml View 1 chunk +0 lines, -29 lines 0 comments Download
D pkg/front_end/front_end.iml View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/meta/meta.iml View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-12 20:37:51 UTC) #2
scheglov
LGTM!
3 years, 7 months ago (2017-05-12 20:38:14 UTC) #3
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-12 20:49:06 UTC) #4
Paul Berry
3 years, 7 months ago (2017-05-12 22:06:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4d3f6cf458810ef58735242e483901956872e5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698