VR Shell: Allow UI elements to determine hit testing.

chrome/browser/android/vr_shell/ui_elements/ui_element.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_H_
 #define CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 97 matching lines @@
                       vr::Mat4f view_proj_matrix) const;
 
   virtual void Initialize();
 
   // Controller interaction methods.
   virtual void OnHoverEnter(gfx::PointF position);
   virtual void OnHoverLeave();
   virtual void OnMove(gfx::PointF position);
   virtual void OnButtonDown(gfx::PointF position);
   virtual void OnButtonUp(gfx::PointF position);
+  // Whether the point (relative to the origin of the element), should be

[cjgrant, 2017/05/15 16:55:09]

- Typo at "by considered".
- What does "local" mean?
- Maybe say that the incoming 0:1 numbers are relative to the quad, and it's up
to the element to consider those according to its specific shape (round button
is a great example).

[mthiesse, 2017/05/15 21:11:27]

What typo?

Clarified the comment and got rid of the term "local".

[cjgrant, 2017/05/15 21:51:52]

"All elements are by considered rectangular by default"

[mthiesse, 2017/05/15 22:23:32]

I do not see the the problem.

fixed ;)

+  // considered on the element. All elements are by considered rectangular by
+  // default. Local points are mapped as follows, though will extend outside the
+  // rectangular bounds of the element:
+  // [(0.0, 0.0), (1.0, 0.0)
+  //  (1.0, 0.0), (1.0, 1.0)]
+  virtual bool HitTest(gfx::PointF point) const;
 
   int id() const { return id_; }
   void set_id(int id) { id_ = id; }
 
   // If a non-negative parent ID is specified, applicable transformations
   // are applied relative to the parent, rather than absolutely.
   int parent_id() const { return parent_id_; }
   void set_parent_id(int id) { parent_id_ = id; }
 
   // If true, this object will be visible.
@@ skipping 164 matching lines @@
   bool dirty_ = false;
 
   Transform transform_;
 
   DISALLOW_COPY_AND_ASSIGN(UiElement);
 };
 
 }  // namespace vr_shell
 
 #endif  // CHROME_BROWSER_ANDROID_VR_SHELL_UI_ELEMENTS_UI_ELEMENT_H_